-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tailwind): swap @tailwindcss/vite for @tailwindcss/postcss #1234
Conversation
some nested components not working with the tailwind vite plugin. the hmr seemed broken when using the tailwind plugin as well. related issue: tailwindlabs/tailwindcss#16585
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tylersayshi ah, we missed |
a follow-up pr for #1234 Co-authored-by: Tyler <26290074+thegitduck@users.noreply.github.com>
@tylersayshi Do you think Waku will switch back to the tailwind plugin instead of postcss since they are addressing the original issue? Does the tailwind vite plugin handle vendor prefixes based on browserslist? I couldn't find any mention of it. |
yes! tailwind released a change that is expected to fix the issues we were seeing, but we do need to still test those changes before recommending it again. If you have time to try out the tailwind vite plugin on your project(s) that would be helpful!
no idea... sounds like a good question for the tailwind discussions board. |
Please be aware we had two issues in the previous plugin. Another one was hot reload, right? |
right! i'd suspect we may need to do some work to integrate the plugin through the waku config |
some nested components not working with the tailwind vite plugin. the hmr seemed broken when using the tailwind plugin as well.
related issue:
tailwindlabs/tailwindcss#16585