Skip to content

Fix matmul formatting #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

Fix matmul formatting #179

merged 1 commit into from
May 12, 2021

Conversation

leofang
Copy link
Contributor

@leofang leofang commented May 12, 2021

Fixing this return list:
截圖 2021-05-12 上午1 38 53

@leofang
Copy link
Contributor Author

leofang commented May 12, 2021

I want to fix norm's formatting as well:

截圖 2021-05-12 上午1 39 45

But the source code looks fine to me...Any ideas?

kgryte
kgryte approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @leofang!

@kgryte
Copy link
Contributor

kgryte commented May 12, 2021

Re: norm. Not sure what is happening. I am seeing that the source formatting to be fine on my end. Possible that something is happening during doc generation. I'll go ahead and merge the current PR as is.

@kgryte kgryte merged commit c2ecccc into data-apis:main May 12, 2021
@leofang leofang deleted the fix_formatting2 branch May 12, 2021 18:40
@leofang leofang mentioned this pull request May 12, 2021
Merged
@leofang
Copy link
Contributor Author

leofang commented May 12, 2021

Re: norm. Not sure what is happening. I am seeing that the source formatting to be fine on my end. Possible that something is happening during doc generation. I'll go ahead and merge the current PR as is.

Thanks, @kgryte. I fixed norm in #181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @kgryte