Skip to content

Commit 00d7c93

Browse files
committed
Update display_by_last_status method (workers.rb) for better performance and updating its tests
1 parent c107b60 commit 00d7c93

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lib/sidekiq/statistic/statistic/workers.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ def display
1818
end
1919

2020
def display_by_last_status
21-
filtered_workers = display.group_by {|worker| worker[:last_job_status] }
21+
filtered_workers = display.group_by { |worker| worker[:last_job_status] }
2222

2323
filtered_workers['passed'] ||= []
2424
filtered_workers['failed'] ||= []
2525

26-
filtered_workers.transform_keys(&:to_sym)
26+
filtered_workers
2727
end
2828

2929
def display_per_day(worker_name)

test/test_sidekiq/statistic_test.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,14 @@ module Statistic
112112

113113
_(subject).must_be_instance_of Hash
114114
assert_equal subject.keys.sort,
115-
%i[passed failed].sort
115+
%w[passed failed].sort
116116

117-
_(subject[:passed]).must_be_instance_of Array
118-
_(subject[:failed]).must_be_instance_of Array
119-
assert_equal subject[:passed][0].keys.sort,
117+
_(subject['passed']).must_be_instance_of Array
118+
_(subject['failed']).must_be_instance_of Array
119+
assert_equal subject['passed'][0].keys.sort,
120120
%i[name last_job_status number_of_calls queue runtime].sort
121121

122-
assert_equal worker, subject[:passed][0][:name]
122+
assert_equal worker, subject['passed'][0][:name]
123123
end
124124
end
125125

0 commit comments

Comments
 (0)