Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file upload disable fakepath #46

Closed
defims opened this issue Mar 9, 2016 · 7 comments
Closed

file upload disable fakepath #46

defims opened this issue Mar 9, 2016 · 7 comments

Comments

@defims
Copy link

defims commented Mar 9, 2016

will be possible disable fakepath when upload file? current webkit implement [html5's fakepath](HTML5's fakepath) because of security, but native app should handle it with nodejs or others, so disable this feature will be nice when develop native app.

@0xWDG
Copy link
Collaborator

0xWDG commented Mar 10, 2016

screen shot 2016-03-10 at 22 17 56

This is a built-in security feature, i don't think it's good to remove it.
you can upload to node.js it all is local, it don't cost any data and takes almost no time to handle a upload.

See file uploads for node.js: https://codeforgeek.com/2014/11/file-uploads-using-node-js/

@defims
Copy link
Author

defims commented Mar 11, 2016

nodejs is nice for uploading file, what i need is the file's fullpath, webshell send the full path to nodejs, and nodejs setup a server of the path.

@0xWDG
Copy link
Collaborator

0xWDG commented Mar 11, 2016

What are you trying to do.
For a normal upload c:\fakepath\file.x doesn't matter.
You can easily remove it with JavaScript...

And it still has no effect on the uploading process.

See also my example if you use input field "name" instead of input field "value" you don't get c:\fakepath

Otherwise make a snippet or something to show what you're trying. Uploading works fine, local and external.

@defims
Copy link
Author

defims commented Mar 12, 2016

what i want like this

@0xWDG
Copy link
Collaborator

0xWDG commented Mar 12, 2016

@djyde what do you think.

If we need this then we need to trigger a event (event.result) after selecting the file, and make some more changes.

Please note, the c:\fakepath\ was introduced for security and now you can see the file system tree (where the file is)

  • file uploading works; issue= if a file is given to the input type="file" then get the local file path.

@djyde
Copy link
Owner

djyde commented Mar 12, 2016

I think WebShell is a browser, not a runtime. This problem should not be solve by WebShell.

@0xWDG
Copy link
Collaborator

0xWDG commented Mar 15, 2016

we have no plans to support this.
maybe in the future, more as a service then a must.

if you think it must be added to WebShell, and you can code yourself then the best solution is to create a pull request.

at least, for now, i close this issue because it has no addition for now.

@0xWDG 0xWDG closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants