Address feedback from peer review and set Node engine version

Author: captainsafia

.vscode/extensions.json

@@ -0,0 +1,8 @@
+{
+	// See https://go.microsoft.com/fwlink/?LinkId=827846
+	// for the documentation about the extensions.json format
+	"recommendations": [
+		"ms-dotnettools.csharp",
+		"k--kato.docomment"
+	]
+}

docs/BuildFromSource.md

@@ -11,11 +11,12 @@ To get started, you'll need to have a fork of the repo cloned locally. This work
 git clone --recursive https://github.com/YOUR_USERNAME/aspnetcore
 ```
 
-3. If you've already cloned the repo without passing the `--recursive` flag, you can fetch submodule sources at any time using:
-
-```
-git submodule update --init --recursive
-```
+> :bulb: If you've already cloned the repo without passing the `--recursive` flag, you can fetch submodule sources at any time using:
+>
+> ```
+> git submodule update --init --recursive
+> ```
+>
 
 The experience for building the repo is slightly different based on what environment you are looking to develop in. Select one of the links below to navigate to the instructions for your environment of choice.
 
@@ -62,8 +63,10 @@ Can't find a solution that has the projects you care about? Feel free to make a
 
 ## Visual Studio Code on Windows, Linux, Mac
 
+> :bulb: The instructions below use Visual Studio code as the editor of choice but the same instructions can be used for any other text editor by replacing the `code` command with an invocation to your editor of choice.
+
 1. In order to use Visual Studio Code for development on this repo, you'll need to have [VS Code](https://code.visualstudio.com/) installed and [the `code` command installed](https://code.visualstudio.com/docs/setup/mac#_launching-from-the-command-line) on your machine.
-2. The repo constains some JavaScript dependencies, so you will need to install [Node](https://nodejs.org/en/) and [yarn](https://yarnpkg.com/) on your machine.
+2. The repo contains some JavaScript dependencies, so you will need to install [Node](https://nodejs.org/en/) and [yarn](https://yarnpkg.com/) on your machine.
 3. Prior to opening the code in Visual Studio code, you'll need to run the `restore` script locally to install the required dotnet dependencies and setup the repo. The `restore` script is located in the root of the repo.
 
 ```bash

src/Components/Web.JS/package.json

@@ -43,5 +43,8 @@
   "resolutions": {
     "**/set-value": "^3.0.2",
     "url-parse": ">=1.5.0"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/Components/WebAssembly/Authentication.Msal/src/Interop/package.json

@@ -27,5 +27,8 @@
   },
   "dependencies": {
     "@azure/msal-browser": "^2.16.1"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/Components/WebAssembly/WebAssembly.Authentication/src/Interop/package.json

@@ -27,5 +27,8 @@
   },
   "dependencies": {
     "oidc-client": "^1.11.5"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/Components/test/E2ETest/package.json

@@ -19,5 +19,8 @@
     "@types/node": "^13.1.7",
     "ts-node": "^8.6.2",
     "typescript": "^3.7.5"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/JSInterop/Microsoft.JSInterop.JS/src/package.json

@@ -29,5 +29,8 @@
     "rimraf": "^3.0.2",
     "tslint": "^6.1.3",
     "typescript": "^4.2.2"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/ProjectTemplates/BlazorTemplates.Tests/package.json

@@ -12,5 +12,8 @@
   "license": "MIT",
   "dependencies": {
     "selenium-standalone": "^7.1.0"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/ProjectTemplates/test/package.json

@@ -12,5 +12,8 @@
   "license": "MIT",
   "dependencies": {
     "selenium-standalone": "^7.1.0"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/SignalR/clients/ts/FunctionalTests/package.json

@@ -57,5 +57,8 @@
     "url-parse": ">=1.5.0"
   },
   "author": "",
-  "license": "MIT"
+  "license": "MIT",
+  "engines": {
+    "node": "16.x"
+  }
 }

src/SignalR/clients/ts/common/package.json

@@ -30,5 +30,8 @@
     "webpack": "^5.24.1",
     "webpack-cli": "^4.5.0"
   },
-  "dependencies": {}
+  "dependencies": {},
+  "engines": {
+    "node": "16.x"
+  }
 }

src/SignalR/clients/ts/package.json

@@ -12,5 +12,8 @@
     "coverage": "node ./common/node_modules/jest/bin/jest.js --config ./jest.config.js --coverage"
   },
   "author": "Microsoft",
-  "license": "MIT"
+  "license": "MIT",
+  "engines": {
+    "node": "16.x"
+  }
 }

src/SignalR/clients/ts/signalr-protocol-msgpack/package.json

@@ -50,5 +50,8 @@
   "devDependencies": {},
   "resolutions": {
     "url-parse": ">=1.5.0"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }

src/SignalR/clients/ts/signalr/package.json

@@ -59,5 +59,8 @@
     "fetch-cookie": "^0.11.0",
     "node-fetch": "^2.6.1",
     "ws": "^7.4.5"
+  },
+  "engines": {
+    "node": "16.x"
   }
 }