Skip to content

[Kestrel] Support for custom decoder for parsing target (e.g. URL) #23490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
halter73 opened this issue Jun 29, 2020 · 4 comments
Open

[Kestrel] Support for custom decoder for parsing target (e.g. URL) #23490

halter73 opened this issue Jun 29, 2020 · 4 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel severity-minor This label is used by an internal tool
Milestone

Comments

@halter73
Copy link
Member

Follow up to #17400. The idea is to make the encoding Kestrel interprets the target as configurable. Currently, Kestrel only accepts ASCII targets. This could be done with something like a "TargetEncoding" Encoding property on KestrelServerOptions.

@halter73
Copy link
Member Author

@lodejard How important is it for you to be able to configure the encoding Kestrel uses to decode request targets?

@blowdart
Copy link
Contributor

Of course we'd leave the default as the properly spec compliant one, won't we?

@halter73
Copy link
Member Author

Of course we'd leave the default as the properly spec compliant one, won't we?

This issue is not about changing the default encoding, just making configurable. #17402 is about whether we should switch the default encoding from ASCII to UTF-8.

@ghost
Copy link

ghost commented Jul 24, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Tratcher Tratcher added affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Oct 6, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

6 participants