Skip to content

Unexpected licenses in MusicStore javascript files #25076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
omajid opened this issue Aug 20, 2020 · 8 comments
Closed

Unexpected licenses in MusicStore javascript files #25076

omajid opened this issue Aug 20, 2020 · 8 comments
Assignees
@Pilchie
Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Milestone
6.0-preview1

Comments

@omajid
Copy link
Member

omajid commented Aug 20, 2020 •
edited
Loading

Most of the files in the MusicStore sample don't include explicit license headers, so I assume they fall under the same license as ASP.NET Core: Apache 2.0

However, the javascript file in the MusicStore project have license headers that aren't a normal open source license.

These files include a license that's very restrictive:

These 2 files mention a copyright, but not a license. Perhaps you can add a license header too?
@omajid
Copy link
Member Author

omajid commented Aug 20, 2020

cc @dleeapho @leecow

@javiercn
Copy link
Member

javiercn commented Aug 21, 2020 •
edited
Loading

@omajid thanks for contacting us.

@Pilchie do you have any thoughts? These things likely point to very old versions of the libraries since we haven't updated this sample in quite a while.

/cc: @dotnet/aspnet-build

@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 21, 2020
@Pilchie
Copy link
Member

Pilchie commented Aug 25, 2020

Agreed. The music store sample is pretty stale. I wonder if it's still providing us the sort of benefit it was intended for.

@omajid
Copy link
Member Author

omajid commented Sep 2, 2020

Any chance the licenses could be fixed up or the non-open-source files be removed?

@omajid omajid mentioned this issue Sep 9, 2020
Closed
@omajid
Copy link
Member Author

omajid commented Sep 21, 2020

Any chance this will be fixed by 5.0 GA?

@Pilchie
Copy link
Member

Pilchie commented Sep 21, 2020

It's quite unlikely at this point.

@Pilchie Pilchie self-assigned this Sep 23, 2020
@Pilchie Pilchie added this to the 6.0.0-alpha1 milestone Sep 23, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 23, 2020

I'm going to look at this along with #18873 early in .NET 6.

@wtgodbe wtgodbe added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
@Pilchie
Copy link
Member

Pilchie commented Nov 17, 2020

I think all of these files just got removed in #27853.

@Pilchie Pilchie closed this as completed Nov 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Pilchie Pilchie

Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Projects
None yet
Milestone
6.0-preview1
Development

No branches or pull requests
4 participants
@omajid @Pilchie @javiercn @wtgodbe