Skip to content

Consider adding a shipping package baseline test #28129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaoK opened this issue Nov 24, 2020 · 5 comments
Open

Consider adding a shipping package baseline test #28129

HaoK opened this issue Nov 24, 2020 · 5 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Nov 24, 2020

As part of the postmortem for a 5.0.1 issue where we needed to mark Identity.Specficiation.Tests as shipping. It seems worth adding a test with baselines to track the total set of packages we ship, similar to how we track the list of assemblies in the shared fx here: https://github.com/dotnet/aspnetcore/blob/master/src/Framework/test/TestData.cs.

The analogy would be something that just enumerates all the nupkgs in the shipping artifacts and fails if there's a mismatch from the list so we can track/be explicitly intentional about changes in the packages we ship.

@HaoK HaoK added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 24, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Dec 16, 2020

Post-build hook in arcade would be useful in creating a check for this. https://github.com/dotnet/aspnetcore/blob/master/eng/AfterSolutionBuild.targets

@JunTaoLuo JunTaoLuo added the severity-minor This label is used by an internal tool label Dec 16, 2020
@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

I'm not sure what would be needed here nor how additional automation would help. If we need to check prior to the release, manifest files e.g. \vsufile\patches\sign\NET\CORE_BUILDS\2.1.X\2.1.31\20210916-02\assets\orchestration-metadata\manifests\aspnet.xml, \vsufile\patches\sign\NET\CORE_BUILDS\3.1.X\3.1.20\3.1.120-servicing-015384\manifest.json, or \vsufile\patches\sign\NET\NET_CORE\5.0.11\configs\manifests\manifest.json are available when internal builds are announced.

Looking back, the eng/Baseline.xml file e.g. https://github.com/dotnet/aspnetcore/blob/release/2.1/eng/Baseline.xml and (for 2.1) https://github.com/dotnet/versions/blob/main/build-info/dotnet/product/cli/release/2.1/build.xml and similar files are available after every release.

/cc @mkArtakMSFT because this relates to validating fixes are in a release

@dougbu dougbu removed this from the Next sprint planning milestone Oct 6, 2021
@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

/btw John's suggestion won't help because we always ship everything in every release, with the minor exception of targeting packs. Where we do incremental shipment (in release/2.1), Arcade isn't involved.

@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

In any case, I have no way to know when we'd do this, if do something, and cleared the milestone for now. Suggestions for "maybe" items @adityamandaleeka @rafikiassumani-msft @mkArtakMSFT @Pilchie

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

5 participants
@JunTaoLuo @dougbu @HaoK @mkArtakMSFT and others