Skip to content

Complete [Typed]Results Json AOT/trimmer-safe overloads #53189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Kumima opened this issue Jan 6, 2024 · 1 comment
Open
1 task done

Complete [Typed]Results Json AOT/trimmer-safe overloads #53189

Kumima opened this issue Jan 6, 2024 · 1 comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc NativeAOT
Milestone
Backlog

Comments

@Kumima
Copy link

Kumima commented Jan 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Related #46252
For now only TypedResults.JsonHttpResult and Results.Json has such overloads.
But methods like TypedResults.Created<TValue>and TypedResults.Accepted<TValue> also do serialization.
Those methods should have the correspond overloads, which will provide help such as setting the default the HTTP Status Code.

Describe the solution you'd like

All methods those do serialization should have AOT/trimmer-safe overloads.

Additional context

No response
@ghost ghost added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels NativeAOT labels Jan 6, 2024
@Kumima Kumima mentioned this issue Jan 6, 2024
Open
1 task
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@captainsafia
Copy link
Member

@Kumima Thanks for filing this issue! Apologies for the delay as I work through the triage backlog. 😅

I'm not opposed to this proposal on principal, although we will have to file a formal API proposal issue given that it changes API shape.

@halter73 Do you recall if there was a specific reason we didn't modify the other result types as part of the original API proposal?

@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Aug 22, 2024
@captainsafia captainsafia added this to the Backlog milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc NativeAOT
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@captainsafia @wtgodbe @Kumima