Skip to content

[Blazor] Investigate why E2E tests aren't catching trimming issues #56344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MackinnonBuck opened this issue Jun 20, 2024 · 1 comment
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Milestone

Comments

@MackinnonBuck
Copy link
Member

We should ensure that Blazor's E2E tests are running against published/trimmed versions of each test app. We've had a few trimming issues that had to be caught manually (e.g., #56333, #53746, #51665).

@MackinnonBuck MackinnonBuck added area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Jun 20, 2024
@MackinnonBuck MackinnonBuck added this to the 9.0-rc1 milestone Jun 24, 2024
@mkArtakMSFT mkArtakMSFT modified the milestones: 9.0-rc1, 9.0-rc2 Aug 2, 2024
@MackinnonBuck MackinnonBuck self-assigned this Aug 12, 2024
@MackinnonBuck
Copy link
Member Author

I did some investigation here and it does look like our E2E tests catch glaring trimming issues.

The challenge with catching more subtle trimming problems is primarily that since the test app (BasicTestApp) is so big, it's more likely to reference code that would otherwise get trimmed out on a smaller app (e.g., a new project).

Thankfully, as of #54606, we are now getting coverage for projects generated from our project templates, and these tests validate that trimmed, published apps work correctly (the counter can be clicked, etc.). I introduced a trimming issue locally to determine if the template tests would catch it, and they did.

Closing this out now as there doesn't seem to be anything more to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

2 participants