-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix ProjectTemplate build steps with new JDK #56199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
84a8831
to
8305762
Compare
@@ -1,5 +1,5 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | |||
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this because building the project keeps changing it back
@@ -22,7 +22,7 @@ allprojects { | |||
// If we're run from outside MSBuild, just assign a bogus dev version. | |||
version project.findProperty('packageVersion') ?: "99.99.99-dev" | |||
|
|||
sourceCompatibility = 1.8 | |||
sourceCompatibility = 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got warnings without that
@@ -78,4 +84,5 @@ class Version { | |||
} | |||
} | |||
|
|||
createPackage.dependsOn 'generatePomFileForMavenJavaPublication' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the internal task that needs to be invoked to trigger publishing
IT's very probable I forgot something, didn't know what gradle was before this PR. At least I checked that the expected assets were generated: The pom file: <?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>com.microsoft.signalr</groupId>
<artifactId>signalr</artifactId>
<version>9.0.0-dev</version>
<packaging>pom</packaging>
<name>com.microsoft.signalr:signalr</name>
<description>ASP.NET Core SignalR Client for Java applications</description>
<url>https://github.com/dotnet/aspnetcore</url>
<inceptionYear>2018</inceptionYear>
<licenses>
<license>
<name>MIT License</name>
<url>https://opensource.org/licenses/MIT</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>microsoft</id>
<name>Microsoft</name>
</developer>
</developers>
<scm>
<connection>scm:git:https://github.com/dotnet/aspnetcore.git</connection>
<developerConnection>scm:git:https://github.com/dotnet/aspnetcore.git</developerConnection>
<url>https://github.com/dotnet/aspnetcore/tree/main</url>
</scm>
</project>
|
Does the CI test the packages and their dependencies? The DSL wrt these dependencies has changed (compile, runtime, test) and I wonder if the final packages have the correct dependencies after this PR, and not too many (like test-only dependencies). |
Thanks @sebastienros! |
This is blocked on dotnet/dnceng#3093 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
@sebastienros is this still blocked? If so, can you please update the milestone of the associated issue so that it isn't sitting in an old milestone? |
Fixes #55975
artifacts\obj\Npm.Workspace\Release\packagesToPack.json
file.After these changes
eng\build.cmd -all -pack -configuration Release
works on my machine.