Skip to content

Add support for multi-line queries #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigoportela opened this issue Jul 1, 2024 · 2 comments · May be fixed by #33
Open

Add support for multi-line queries #12

rodrigoportela opened this issue Jul 1, 2024 · 2 comments · May be fixed by #33
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rodrigoportela
Copy link

The plugin doesn't seem to work when the Dataview query is written in several lines. I thought the plugin wasn't working at all when doing some tests pasting multiline Dataview queries that were working in Dataview codeblocks without any problem, until editing the queries to be only one line together with the opening and closing parts of the HTML comment as well. Is this the intended behavior for some reason or a bug? Reporting here in case it's a bug. I also tried using soft line breaks (shift + enter).

Nothing essential, but it would be nice to be able to use the plugin without having long queries fit one line.

@dsebastien dsebastien added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 2, 2024
@dsebastien
Copy link
Owner

Hello,

Indeed, the code currently looks at lines one at a time. I could refactor it later to handle multi-line queries, but have little time available to focus on that now. Feel free to send a pull request if you're motivated! :)

For now, I'll mention this limitation in the documentation.

@dsebastien dsebastien changed the title Only working with single lines Add support for multi-line queries Jul 2, 2024
@rodrigoportela
Copy link
Author

Hello,

Indeed, the code currently looks at lines one at a time. I could refactor it later to handle multi-line queries, but have little time available to focus on that now. Feel free to send a pull request if you're motivated! :)

For now, I'll mention this limitation in the documentation.

Thank you for confirming how it's supposed to work and that it may be changed.

Unfortunately, I'm more motivated than capable not being a developer and not having tried to understand how that code works. So let's better wait for another person to fix it. :)

@yoyossef yoyossef linked a pull request Dec 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants