From 2af8df37bf5dd537f7a78476b0795d64cdfaab9e Mon Sep 17 00:00:00 2001
From: Jialecl <jialestrabajos@gmail.com>
Date: Wed, 13 Apr 2022 11:57:32 +0200
Subject: [PATCH 1/2] Adding defaultChecked to checkbox component

---
 .../checkbox-preview/checkbox-preview.component.html   | 10 ++++++++++
 .../checkbox-preview/checkbox-preview.component.ts     |  2 +-
 .../lib/dxc-checkbox/dxc-checkbox.component.spec.ts    |  7 ++++---
 .../src/lib/dxc-checkbox/dxc-checkbox.component.ts     |  6 +++++-
 .../src/lib/dxc-checkbox/dxc-checkbox.types.ts         |  1 +
 5 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.html b/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.html
index e456308cd..5325bdd9d 100644
--- a/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.html
+++ b/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.html
@@ -11,6 +11,16 @@
       </dxc-checkbox>
     </tbuilder-component-mode>
 
+    <tbuilder-component-mode text="Default Checked">
+      <dxc-checkbox
+        [defaultChecked]="true"
+        label="Label"
+        margin="xsmall"
+      >
+      </dxc-checkbox>
+    </tbuilder-component-mode>
+
+
     <tbuilder-component-mode text="Label Position">
       <dxc-checkbox
         [checked]="checked2"
diff --git a/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.ts b/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.ts
index 4bc49bc6d..36e1a27ad 100644
--- a/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.ts
+++ b/projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/checkbox-preview/checkbox-preview.component.ts
@@ -6,7 +6,7 @@ import { Component, OnInit } from '@angular/core';
 })
 export class CheckboxPreviewComponent implements OnInit {
 
-  checked1: boolean = false;
+  checked1: boolean = true;
   checked2: boolean = false;
   checked3: boolean = false;
 
diff --git a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.spec.ts b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.spec.ts
index 4db5e8903..42f12f3f1 100644
--- a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.spec.ts
+++ b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.spec.ts
@@ -26,6 +26,7 @@ describe("DxcCheckbox tests", () => {
     const dxcCheckbox = await render(DxcCheckboxComponent, {
       componentProperties: {
         label: "test-checkbox",
+        defaultChecked: true,
         onChange: { emit: onClickFunction } as any,
       },
       imports: [MatCheckboxModule],
@@ -33,11 +34,11 @@ describe("DxcCheckbox tests", () => {
     expect(dxcCheckbox);
 
     const input = <HTMLInputElement>dxcCheckbox.getByRole("checkbox");
-    expect(input.checked).toBeFalsy();
+    expect(input.checked).toBeTruthy();
     const dxcInput = dxcCheckbox.getByText("test-checkbox");
     fireEvent.click(dxcInput);
-    expect(onClickFunction).toHaveBeenCalledWith(true);
-    expect(input.checked).toBeTruthy();
+    expect(onClickFunction).toHaveBeenCalledWith(false);
+    expect(input.checked).toBeFalsy();
   });
 
   test("Controlled dxc-checkbox", async () => {
diff --git a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
index af19cccb1..593e06385 100644
--- a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
+++ b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
@@ -37,6 +37,9 @@ export class DxcCheckboxComponent implements OnInit {
   }
   private _checked;
 
+  @Input()
+  defaultChecked: boolean = false;
+
   /**
    * Will be passed to the value attribute of the html input element. When inside a form,
    * this value will be only submitted if the checkbox is checked.
@@ -125,6 +128,7 @@ export class DxcCheckboxComponent implements OnInit {
 
   defaultInputs = new BehaviorSubject<CheckboxProperties>({
     checked: false,
+    defaultChecked: false,
     value: null,
     label: null,
     labelPosition: "before",
@@ -173,7 +177,7 @@ export class DxcCheckboxComponent implements OnInit {
   }
 
   ngOnInit() {
-    this.renderedChecked = this.checked;
+    this.renderedChecked = this.checked || this.defaultChecked;
 
     this.className = `${this.getDynamicStyle(this.defaultInputs.getValue())}`;
     if (this.disabled) {
diff --git a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.types.ts b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.types.ts
index a8856e79e..c81801737 100644
--- a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.types.ts
+++ b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.types.ts
@@ -16,6 +16,7 @@ export type Spacing = {
 
 export interface CheckboxProperties {
   checked?: boolean;
+  defaultChecked?: boolean;
   value?: string;
   label: string;
   labelPosition?: "before" | "after";

From e72d35ef8dc6e2d304ea05928c47fb54a9eeffb0 Mon Sep 17 00:00:00 2001
From: Jialecl <jialestrabajos@gmail.com>
Date: Wed, 13 Apr 2022 13:41:08 +0200
Subject: [PATCH 2/2] Adding documentation

---
 .../checkbox-properties/checkbox-properties.component.html | 7 +++++++
 .../src/lib/dxc-checkbox/dxc-checkbox.component.ts         | 3 +++
 2 files changed, 10 insertions(+)

diff --git a/projects/dxc-ngx-cdk-site/src/app/components/examples/checkbox/properties/checkbox-properties/checkbox-properties.component.html b/projects/dxc-ngx-cdk-site/src/app/components/examples/checkbox/properties/checkbox-properties/checkbox-properties.component.html
index 2c45f8a4c..9fb8650c0 100644
--- a/projects/dxc-ngx-cdk-site/src/app/components/examples/checkbox/properties/checkbox-properties/checkbox-properties.component.html
+++ b/projects/dxc-ngx-cdk-site/src/app/components/examples/checkbox/properties/checkbox-properties/checkbox-properties.component.html
@@ -18,6 +18,13 @@
       uncontrolled and the value will be managed internally by the component.
     </td>
   </tr>
+  <tr>
+    <td>defaultChecked: boolean</td>
+    <td><code>false</code></td>
+    <td>
+      Initial state of the checkbox, only when it is uncontrolled.
+    </td>
+  </tr>
   <tr>
     <td>value: string</td>
     <td></td>
diff --git a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
index 593e06385..26697c491 100644
--- a/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
+++ b/projects/dxc-ngx-cdk/src/lib/dxc-checkbox/dxc-checkbox.component.ts
@@ -37,6 +37,9 @@ export class DxcCheckboxComponent implements OnInit {
   }
   private _checked;
 
+  /**
+   * 	Initial state of the checkbox, only when it is uncontrolled.
+   */
   @Input()
   defaultChecked: boolean = false;