Skip to content

Move to new implementation of Descriptors and Parameters #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
andped10 opened this issue Jul 3, 2024 · 1 comment · Fixed by #94
Open
1 of 2 tasks

Move to new implementation of Descriptors and Parameters #23

andped10 opened this issue Jul 3, 2024 · 1 comment · Fixed by #94
Assignees

Comments

@andped10
Copy link
Contributor

andped10 commented Jul 3, 2024

Required clean when moving to the new structure of Descriptors and Parameters.

First we need to confirm that the new descriptors a parameters are working in:

To clean the code base:

search for

  • .Variable import Descriptor and delete
  • .Variable import Parameter and delete

delete legacy tests:

  • tests/integration_tests/Fitting/test_fitter_legacy_parameter.py
  • tests/integration_tests/Fitting/test_multi_fitter_legacy_parameter.py
  • tests/unit_tests/Fitting/test_constraints_legacy_parameter.py

rename folder: new_variable -> variable

Following files should be cleaned:

  • pyproject.toml, pint is no longer a requirement
  • src/easyscience/Objects/Inferface.py, clean up TODO sections
  • src/easyscience/Objects/ObjectClasses.py, clean up TODO sections
  • src/easyscience/fitting/Constraints.py, clean up TODO sections
  • src/easyscience/fitting/minimizers/minimizer_bumps.py, clean up TODO sections
  • src/easyscience/fitting/minimizers/minimizer_lmfit.py, clean up TODO sections
  • tests/unit_tests/Fitting/test_constraints_legacy_parameter.py, delete
    -tests/unit_tests/Objects/new_variable/test_descriptor_from_legacy.py, rename
  • tests/unit_tests/Objects/new_variable/test_parameter_from_legacy.py, rename

Probably able to move to numpy 2

@henrikjacobsenfys
Copy link
Member

henrikjacobsenfys commented Jan 20, 2025

Completed in #94
We still need to check and update EasyDiffraction and EasyCrystallography.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants