Skip to content

Move cif/star related methods to EasyCrystallography #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rozyczko opened this issue Jul 16, 2024 · 0 comments · Fixed by #35
Closed

Move cif/star related methods to EasyCrystallography #28

rozyczko opened this issue Jul 16, 2024 · 0 comments · Fixed by #35
Assignees
@rozyczko
Labels
chore PR label
Milestone
Milestone 1

Comments

@rozyczko
Copy link
Member

src/easyscience/Utils/io/star.py should be moved to easycrystallography.

The CIF/STAR format is technique-specific, so should not be in the generic core module.
@rozyczko rozyczko added the chore PR label label Jul 16, 2024
This was referenced Jul 16, 2024
Closed
Merged
@rozyczko rozyczko self-assigned this Jul 17, 2024
@damskii9992 damskii9992 linked a pull request Jul 17, 2024 that will close this issue
Delete STAR parser #35
Merged
@rozyczko rozyczko added this to the Milestone 1 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozyczko rozyczko

Labels
chore PR label
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging a pull request may close this issue.

Delete STAR parser easyscience/corelib
1 participant
@rozyczko