Skip to content

Replace constraints with dependent Parameters #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damskii9992 opened this issue Jul 16, 2024 Discussed in #10 · 0 comments · May be fixed by #112
Open

Replace constraints with dependent Parameters #34

damskii9992 opened this issue Jul 16, 2024 Discussed in #10 · 0 comments · May be fixed by #112
Assignees
Labels
[area] Parameters and Descriptors Anything related to Parameters or Descriptors [priority] medium Normal/default priority [scope] significant Breaking or major changes (MAJOR.minor.patch)
Milestone

Comments

@damskii9992
Copy link
Contributor

damskii9992 commented Jul 16, 2024

Discussed in #10

Originally posted by damskii9992 June 7, 2024

Requirements

  • When an independent parameter value is changed, it should update the values of all the parameters which depend directly on it. When doing this update, signals should also be send to the GUI frontend to reflect this change.
  • Making a parameter dependent should be easy and user-friendly, both when generated and when changed by the setter, by allowing direct expressions such as: 'value=a+2*b' in the value field
  • A dependent parameter should also be easy to change back into an independent parameter
  • Dependent parameters should not be included in the fitting procedure
  • [Optional] It should be possible to visualize a dependency tree to get an overview of all parameter dependencies

Implementation

  • '_is_independent' boolean variable, for checks
  • 'list_of_dependents' list variable with UIDs of parameters that depend on the parameter
  • '_update' method, to be called on dependent parameters when their independent dependency is changed
  • Logic to ensure no broken, cyclic or secondary (for now) dependencies
@damskii9992 damskii9992 added [scope] enhancement Adds/improves features (major.MINOR.patch) chore PR label labels Jul 16, 2024
@damskii9992 damskii9992 self-assigned this Jul 16, 2024
@damskii9992 damskii9992 changed the title ADR Suggestion, Dependent Parameters Replace constraints with dependent Parameters Jul 16, 2024
@rozyczko rozyczko added this to the Milestone 1 milestone Jul 31, 2024
@damskii9992 damskii9992 added [priority] medium Normal/default priority [area] Parameters and Descriptors Anything related to Parameters or Descriptors [scope] significant Breaking or major changes (MAJOR.minor.patch) and removed chore PR label [scope] enhancement Adds/improves features (major.MINOR.patch) labels Apr 1, 2025
@damskii9992 damskii9992 linked a pull request Apr 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[area] Parameters and Descriptors Anything related to Parameters or Descriptors [priority] medium Normal/default priority [scope] significant Breaking or major changes (MAJOR.minor.patch)
Projects
None yet
2 participants