Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server integration should respect empty LS capabilities #2695

Closed
evidolob opened this issue Oct 4, 2016 · 0 comments
Closed

Language Server integration should respect empty LS capabilities #2695

evidolob opened this issue Oct 4, 2016 · 0 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current

Comments

@evidolob
Copy link
Contributor

evidolob commented Oct 4, 2016

According to spec of ServerCapabilities object all LS capabilities are optional.
We should respect that. For now we have NPE when LS don't provide textDocumentSync :

TextDocumentSynchronizeFactory.java:40 Uncaught (in promise) TypeError: Cannot read property 'ordinal_0' of undefined(…)getSynchronize@
 TextDocumentSynchronizeFactory.java:40
 LanguageServerReconcileStrategy@ LanguageServerReconcileStrategy.java:43
 org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerReconcileStrategy_org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerReconcileStrategy_methodInjection_ @ org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:164
 assistedInject_buildKey$type$org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerReconcileStrategyFactory$_annotation$$none$$ @
 org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:168
 build_7 @ org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:152
 LanguageServerEditorConfiguration @ LanguageServerEditorConfiguration.java:65
 org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerEditorConfiguration_org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerEditorConfiguration_methodInjection_ @ org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:88
 assistedInject_buildKey$type$org$eclipse$che$plugin$languageserver$ide$editor$LanguageServerEditorConfigurationFactory$_annotation$$none$$ @ org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:92build_6 @ org_eclipse_che_ide_client_inject_IDEInjector_IDEInjectorGinjector_fragment.java:76
 apply_1003 @ LanguageServerEditorProvider.java:98
 apply_1004 @ LanguageServerEditorProvider.java:96
 (anonymous function) @ JsPromise.java:78
@evidolob evidolob added kind/bug Outline of a bug - must adhere to the bug report template. team/ide labels Oct 4, 2016
@evidolob evidolob self-assigned this Oct 4, 2016
@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 25, 2016
@evidolob evidolob added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 25, 2016
@evidolob evidolob removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current
Projects
None yet
Development

No branches or pull requests

2 participants