CODENVY-562: Clean up container if it failed to start #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
@AndrienkoAleksandr @skabashnyuk take a look, please |
|
Ok for me. +1 |
|
Build # 152 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/152/ to view the results. |
|
+0 |
|
LGTM |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CODENVY-562: Clean up container if it failed to start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug, when Codenvy system newer removes containers which failed to start.
What issues does this PR fix or reference?
Codenvy/562
Previous Behavior
All failed containers are not cleaned. Swarm reserves memory for them and after some time system will fail to start any new container (because all memory is reserved for dead containers).
New Behavior
Removes all containers which are failed to start
Tests written?
No
Docs requirements?
No