CHE-1485 allow special characters in file names and folder names + fix an encoding issue #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com>
Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
By the way I think all the file names passed as a query string parameter to the API should be URL Encoded. I supposed because of that, some operation may be broken when executed against files containing special chars in their names. This is also my first contribution to Che :) |
…l chars in its name Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com>
|
Thanks for the contribution! @kuleshov @vparfonov should review and comment. |
bmicklea
added
the
status/code-review
|
@vparfonov : could you please have your team reviewing the PR. |
|
@vparfonov : still no review planned on this PR? |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…x an encoding issue (eclipse-che#2176) * CHE-1485 allow special characters in file names Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com> * CHE-1485 fix encoding issues with special chars when creating new file Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com> * CHE-1485 fix encoding issue when copying or moving a file with special chars in its name Signed-off-by: Paul-Julien Vauthier <pj82491@gmail.com>
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows user to create files and folders that contains special (non-ASCII) characters expects the one that are not allowed in Linux or Windows.
What issues does this PR fix or reference?
CHE-1485 Struggling working with Japanese filenames
Previous Behavior
File/Folder names with special characters were marked as invalid
New Behavior
File/Folder names with special characters are now valid
Tests written?
Yes
Docs requirements?
None
Note that Japanese names for example makes the terminal to behave a bit weirdly. However by getting into the container it is fine (see screenshot).