Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2649 : Allow on Mac to use alt + 5 which is for example used to type { #2656

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 29, 2016

What does this PR do?

Fix issue on Mac not allowing to enter {

What issues does this PR fix or reference?

#2649

PR type

  • Minor change = no change to existing features or docs

Minor change checklist

  • New API required?
  • API updated
  • Tests provided / updated
  • Tests passed

Change-Id: I632415dfc97eaac87cdfc16649056fa198d4f033
Signed-off-by: Florent BENOIT fbenoit@codenvy.com

… { (map to use action keybinding instead of alt)

Change-Id: I632415dfc97eaac87cdfc16649056fa198d4f033
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. sprint/current labels Sep 29, 2016
Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@benoitf benoitf changed the title Fix #2649 : Allow on Mac to use alt + 5 which is for example to enter… Fix #2649 : Allow on Mac to use alt + 5 which is for example used to type { Sep 29, 2016
@benoitf
Copy link
Contributor Author

benoitf commented Sep 29, 2016

@vparfonov @tolusha

@codenvy-ci
Copy link

Build # 569 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/569/ to view the results.

@tolusha
Copy link
Contributor

tolusha commented Sep 29, 2016

+1

@benoitf benoitf merged commit bd5a9af into master Sep 30, 2016
@benoitf benoitf deleted the CHE-2649 branch September 30, 2016 07:36
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. and removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 30, 2016
@benoitf benoitf added this to the 5.0.0-M5 milestone Sep 30, 2016
@benoitf benoitf self-assigned this Sep 30, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…le to enter { (map to use action keybinding instead of alt) (eclipse-che#2656)

Change-Id: I632415dfc97eaac87cdfc16649056fa198d4f033
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants