Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Fixes - Proxy, Native Mode #3360

Merged
merged 6 commits into from
Dec 13, 2016
Merged

CLI Fixes - Proxy, Native Mode #3360

merged 6 commits into from
Dec 13, 2016

Conversation

TylerJewell
Copy link

What does this PR do?

  1. Adds --noproxy for curl() method since curl command does not inherit that from environment variables.
  2. Fixes issue where there are two names required for the docker-compose.yml file needed by other CLIs.

Tyler Jewell added 2 commits December 12, 2016 10:18
@codenvy-ci
Copy link

Build # 1296 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1296/ to view the results.

mshaposhnik
mshaposhnik approved these changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@mshaposhnik mshaposhnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated a bit, there was a problem with quotes around the arguments

@mshaposhnik
Copy link
Contributor

And BTW we need same method override for CODENVY like:

if [ ! -z ${CODENVY_HOST+x} ]; then
  	   NO_PROXY_CONFIG_FOR_CURL=("--noproxy" "${CODENVY_HOST} ")
  	 fi

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1301/

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1308/

@TylerJewell TylerJewell merged commit 7c59468 into master Dec 13, 2016
@TylerJewell TylerJewell deleted the cli-fixup branch December 13, 2016 16:57
@TylerJewell TylerJewell added this to the 5.0.0-M9 milestone Dec 13, 2016
@TylerJewell TylerJewell added the kind/bug Outline of a bug - must adhere to the bug report template. label Dec 13, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
CLI Fixes - Proxy, Native Mode (eclipse-che#3360)
ee2c530 
* fix proxy

* fixup

* fixup! fixup

* fixup

* fixup! fixup! fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshaposhnik mshaposhnik mshaposhnik approved these changes

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerJewell @codenvy-ci @mshaposhnik