Added {% include base.html %} to all markdown. #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to some files. Added docs/assets/images to .gitignore .
bmicklea
approved these changes
Dec 22, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1438/ |
slemeur
approved these changes
Dec 23, 2016
|
Seems your commits are not signed off - so the ip-validation is failing |
added 3 commits
December 23, 2016 16:10
…n to some files. Added docs/assets/images to .gitignore . Signed-off-by: James Drummond <jdrummond@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1452/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Added {% include base.html %} to all markdown. Add license information to some files. Added docs/assets/images to .gitignore .
* Added {% include base.html %} to all markdown. Add license information to some files. Added docs/assets/images to .gitignore .
Signed-off-by: James Drummond <jdrummond@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added {% include base.html %} to all markdown. Add license information to some files. Added docs/assets/images to .gitignore . Remove assembly as it should not be used for building. Only the _config.yml file should ever be used for building static html docs.
What does this PR do?
The {{ base }} variable does not inherit from base html files. There we need to include the base.html in each markdown. It is included directly below the front matter so it should be easy for contributors to add for new pages.