fix cli tty issue #3683
Merged
fix cli tty issue #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's get verification from @benoitf that removing tty from _test, _dir, _action will not affect the user output at all. If he +1 that, then you have my approval. |
TylerJewell
approved these changes
Jan 11, 2017
|
I'm unsure for actions like ssh as we need a tty afaik |
|
Ok - so @riuvshin - let's make sure that we are not removing tty for end user initiated commands which are _ssh, _dir, and maybe _action. |
added 2 commits
January 12, 2017 01:14
|
@benoitf @TylerJewell reverted |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1591/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* fix cli tty issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not use
-tin CLI because this break CLI usage from non tty environments like CI.