CHE-2813 update style for popups in Dashboard #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1698/ |
akurinnoy
approved these changes
Jan 20, 2017
|
@olexii4 please check the docs on modified popups - to be sure docs contain the same one. |
|
@ashumilova the docs doesn't contain these popups |
olexii4
force-pushed
the
CHE-2813
branch
2 times, most recently
from
7e94c94 to
8b85d69
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1744/ |
ashumilova
reviewed
Jan 24, 2017
| }, (error) => { | ||
| this.cheNotification.showError(error.data && error.data.message ? error.data.message : 'Edit registry error.'); | ||
| }, (error: any) => { | ||
| this.cheNotification.showError(error.data && error.data.message ? error.data.message : 'Error.'); |
There was a problem hiding this comment.
'Error.' - add more description
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1747/ |
|
Following dialogs also should be fixed:
|
|
|
ashumilova
approved these changes
Jan 24, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1757/ |
slemeur
approved these changes
Jan 25, 2017
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
slemeur
added
the
kind/enhancement
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CHE-2813 update style for popups in Dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel oorel@codenvy.com
What does this PR do?
Update style for popups in Dashboard
What issues does this PR fix or reference?
#2813
Changelog and Release Note Information
Changelog
Update style for popups.
Release notes: