Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved functional tests to cli dir to avoid circular dependency #3899

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Moved functional tests to cli dir to avoid circular dependency #3899

merged 1 commit into from
Jan 25, 2017

Conversation

mlabuda
Copy link

@mlabuda mlabuda commented Jan 25, 2017

What does this PR do?

CLI tests moved from base folder to cli folder what is more appropriate place to keep them. It removed circular dependency, now there is left only dependency on eclipse/che-bats image.

What issues does this PR fix or reference?

fixes #3882

Changelog and Release Note Information

Changelog

Moved CLI functional tests from base directory to cli directory

Release Notes: N/A

Docs Pull Request

eclipse-che/che-docs#99

Signed-off-by: Marian Labuda <mlabuda@redhat.com>
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 25, 2017
@benoitf
Copy link
Contributor

benoitf commented Jan 25, 2017

@riuvshin ?

Copy link
Contributor

@riuvshin riuvshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlabuda @benoitf does those changes means that bats image should be built before che-cli now?

@benoitf
Copy link
Contributor

benoitf commented Jan 25, 2017

@riuvshin yes

@benoitf benoitf added this to the 5.2.0 milestone Jan 25, 2017
@benoitf benoitf merged commit daf134e into eclipse-che:master Jan 25, 2017
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circular dependency in dockerfiles
5 participants