CHE-3883: fix creating a custom stack #4224

akurinnoy · 2017-02-24T10:37:22Z

What does this PR do?

This PR fixes some problems faced by user when they creating a custom stack.

fixed bug which allowed to apply to machine a nonunique name
added ability to edit machine's source
added ability to delete the machine with ws-agent activated
added label to mark the dev machine in runtime

Label for dev machine:

Popups on removal the dev machine:

User can select another machine for ws-agent to activate
The only machine in stack

Machine details without background and more compact

What issues does this PR fix or reference?

#3819
#3883
codenvy/codenvy#1578

Changelog

[UD] fixed bugs when modifying machine definitions for custom stacks.
[UD] machine details uses available space more efficiently

Release Notes

n/a

Docs PR

codenvy-ci · 2017-02-24T11:53:19Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2044/

codenvy-ci · 2017-02-28T12:22:07Z

Build # 2058 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2058/ to view the results.

slemeur · 2017-02-28T15:32:00Z

@akurinnoy could you please prepare missing pieces to complete the review?

- allow user to rename any machine - fix checking for machine name uniqueness Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

- add ability to delete the dev machine - add label to mark the dev machine - fix karma tests - add protractro tests Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

akurinnoy · 2017-02-28T17:10:39Z

@slemeur done
@ashumilova @benoitf @olexii4 please review

codenvy-ci · 2017-03-01T00:21:10Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2068/

ashumilova · 2017-03-01T09:36:01Z

...nvironments/machine-config/delete-dev-machine-dialog/delete-dev-machine-dialog.controller.ts

+/**
+ * This class is handling the controller for deleting machines dialog.
+ *
+ * @author Ann Shumilova


ashumilova · 2017-03-01T09:36:44Z

...nvironments/machine-config/delete-dev-machine-dialog/delete-dev-machine-dialog.controller.ts

+   */
+  private isProcessing: boolean = false;
+  /**
+   * Machine name which will be configured ad dev-machine


ad dev-machine - as dev-machine

ashumilova · 2017-03-01T09:41:12Z

.../environments/machine-config/edit-machine-name-dialog/edit-machine-name-dialog.controller.ts


  /**
   * Default constructor that is using resource
   * @ngInject for Dependency injection
   */
-  constructor($mdDialog) {
+  constructor(private $mdDialog: ng.material.IDialogService) {


why private here is needed?

it's a way to create and initialize a member in one place
see Parameter properties in Classes

olexii4 · 2017-03-01T10:08:48Z

.../environments/machine-config/edit-machine-name-dialog/edit-machine-name-dialog.controller.ts

+    let nameRE = new RegExp('^' + name + '$', 'i');
+    return this.machinesNames.some((_name: string) => {
+      return nameRE.test(_name);
+    }) === false;


If it done because we show names in upercase - we can use old one check and use convert the string to uppercase or lowercase letters in bought cases(when we use machineNames and when we check input name name). But use machineNamesUppercase and nameUppercase. As for me it would be more clear.

WDYT?

I agree, will update the PR

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

benoitf

Copyright headers are missing on .js files

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

codenvy-ci · 2017-03-01T16:27:34Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2075/

JamesDrummond · 2017-03-24T16:26:44Z

@bmicklea Should have this in release notes? Could be a big deal for some. I am just about to start on docs for it.

bmicklea · 2017-03-24T22:24:17Z

yes, @JamesDrummond add release notes please

slemeur · 2017-03-27T07:54:11Z

All of these are bug fixes in the workspace's edition screen.

Rule 1: It is not possible to remove workspace's machine when there is only one machine configured in the workspace.
Action: Instead of showing a meaningless error notification, we now display a warning message to the user when he wants to proceed this action.

Rule 2: There must be only one of the workspace's machine with the "ws-agent" active.
Action1: We had a small "dev" tag next to the name of the workspace's machine with the "ws-agent" in order to avoid the user having to unfold all of the workspace's machine to identify which one is having the "ws-agent" activated and used as dev-machine.
Action2: Instead of blocking the user to delete the machine with the "ws-agent", we now ask the user to select which of the other machines must get the "ws-agent" activated.

@JamesDrummond + @bmicklea : I'll handle the release note on that.

* CHE-3883: fix creating a custom stack - allow user to rename any machine - fix checking for machine name uniqueness Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * remove obsolete protractor tests Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * add protractor tests for stacks Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * code clean-up Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-3883: add ability to delete the dev machine - add ability to delete the dev machine - add label to mark the dev machine - fix karma tests - add protractro tests Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-3819: decrease label container width Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * fixes Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * add missing copyright headers Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

slemeur added this to the 5.4.0 milestone Feb 27, 2017

slemeur added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 27, 2017

akurinnoy force-pushed the CHE-3883 branch from 9efa2d4 to a386d63 Compare February 28, 2017 08:34

bmicklea self-requested a review February 28, 2017 15:27

bmicklea approved these changes Feb 28, 2017

View reviewed changes

slemeur self-requested a review February 28, 2017 15:31

slemeur approved these changes Feb 28, 2017

View reviewed changes

Oleksii Kurinnyi added 5 commits February 28, 2017 18:07

CHE-3883: fix creating a custom stack

24dc25c

- allow user to rename any machine - fix checking for machine name uniqueness Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

remove obsolete protractor tests

a4db843

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

add protractor tests for stacks

af5bb46

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

code clean-up

02dbc3b

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

CHE-3883: add ability to delete the dev machine

303f48c

- add ability to delete the dev machine - add label to mark the dev machine - fix karma tests - add protractro tests Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

akurinnoy force-pushed the CHE-3883 branch from a386d63 to 4120b64 Compare February 28, 2017 16:26

CHE-3819: decrease label container width

736cdae

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

akurinnoy force-pushed the CHE-3883 branch from 4120b64 to 736cdae Compare February 28, 2017 17:09

akurinnoy requested review from ashumilova, benoitf and olexii4 February 28, 2017 17:09

akurinnoy changed the title ~~[WIP] CHE-3883: fix creating a custom stack~~ CHE-3883: fix creating a custom stack Feb 28, 2017

ashumilova reviewed Mar 1, 2017

View reviewed changes

olexii4 reviewed Mar 1, 2017

View reviewed changes

olexii4 approved these changes Mar 1, 2017

View reviewed changes

fixes

19aa1e5

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

benoitf approved these changes Mar 1, 2017

View reviewed changes

olexii4 approved these changes Mar 1, 2017

View reviewed changes

add missing copyright headers

1cf68a9

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>

akurinnoy merged commit 4325d38 into master Mar 1, 2017

akurinnoy deleted the CHE-3883 branch March 3, 2017 08:49

JamesDrummond mentioned this pull request Mar 8, 2017

5.4.0 Milestone Overview #4176

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHE-3883: fix creating a custom stack #4224

CHE-3883: fix creating a custom stack #4224

akurinnoy commented Feb 24, 2017 •

edited

Loading

codenvy-ci commented Feb 24, 2017

codenvy-ci commented Feb 28, 2017

slemeur commented Feb 28, 2017

akurinnoy commented Feb 28, 2017

codenvy-ci commented Mar 1, 2017

ashumilova Mar 1, 2017

ashumilova Mar 1, 2017

ashumilova Mar 1, 2017

akurinnoy Mar 1, 2017

olexii4 Mar 1, 2017

akurinnoy Mar 1, 2017

benoitf left a comment

codenvy-ci commented Mar 1, 2017

JamesDrummond commented Mar 24, 2017

bmicklea commented Mar 24, 2017

slemeur commented Mar 27, 2017

CHE-3883: fix creating a custom stack #4224

CHE-3883: fix creating a custom stack #4224

Conversation

akurinnoy commented Feb 24, 2017 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Docs PR

codenvy-ci commented Feb 24, 2017

codenvy-ci commented Feb 28, 2017

slemeur commented Feb 28, 2017

akurinnoy commented Feb 28, 2017

codenvy-ci commented Mar 1, 2017

ashumilova Mar 1, 2017

Choose a reason for hiding this comment

ashumilova Mar 1, 2017

Choose a reason for hiding this comment

ashumilova Mar 1, 2017

Choose a reason for hiding this comment

akurinnoy Mar 1, 2017

Choose a reason for hiding this comment

olexii4 Mar 1, 2017

Choose a reason for hiding this comment

akurinnoy Mar 1, 2017

Choose a reason for hiding this comment

benoitf left a comment

Choose a reason for hiding this comment

codenvy-ci commented Mar 1, 2017

JamesDrummond commented Mar 24, 2017

bmicklea commented Mar 24, 2017

slemeur commented Mar 27, 2017

akurinnoy commented Feb 24, 2017 •

edited

Loading