[cli] - Add check for exec on file system #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2017 06:17
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
garagatyi
approved these changes
Mar 6, 2017
| if ! is_fast; then | ||
| check_host_volume_mount | ||
| fi | ||
| return 2 |
There was a problem hiding this comment.
Looks like indentation is not alligned
There was a problem hiding this comment.
Oops - indentation is correct. That return statement should not be there. Removed.
added 2 commits
March 6, 2017 06:42
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
TylerJewell
added
the
kind/enhancement
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2113/ |
garagatyi
reviewed
Mar 7, 2017
| @@ -16,6 +16,7 @@ help_cmd_start() { | |||
| text "Starts ${CHE_MINI_PRODUCT_NAME} and verifies its operation\n" | |||
| text "\n" | |||
| text "PARAMETERS:\n" | |||
| text " --follow Displays server logs to console and blocks until user interrupts\n" | |||
garagatyi
approved these changes
Mar 7, 2017
TylerJewell
pushed a commit
to eclipse-che/che-docs
that referenced
this pull request
Mar 7, 2017
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Tyler Jewell <tjewell@codenvy.com> * exec check * add --follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a check for the ability to execute a file on the file system mounted to
:/data. Also adds in the ability to skip this check if--fastis provided on the command line. We previously checked to see if the file system is writable, but never checked to see if files could execute on the system.Also adds in
--followoption to the start command which will provide blocking following of Che logs to the output screen. This will not let you know when the server has finished booting. The user must provide CTRL-C on the command line to kill this process.What issues does this PR fix or reference?
codenvy/codenvy#1877 (comment)
Changelog
[cli] Add check to ensure
:/datacan execute files written to it from a container[cli] Add
--followparameter to start command to follow logs while bootingRelease Notes
In the CLI, as part of the
startcommand, you can now optionally provide the--followflag which will provide a blocking follow of the logs of the Che server.Docs PR
eclipse-che/che-docs#164
codenvy/docs#94