Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance trace_methods to capture arguments and return types #427

Open
eyalkoren opened this issue Jan 17, 2019 · 1 comment
Open

Enhance trace_methods to capture arguments and return types #427

eyalkoren opened this issue Jan 17, 2019 · 1 comment
Labels
enhancement Enhancement of an existing feature instrumentation Instrumentation: framework support, custom plugins, ...

Comments

@eyalkoren
Copy link
Contributor

We may use tags for that. The idea is to capture natives and strings up to limited number of characters and capturing Objects using a syntax that provides an accessor to use, for example co.elastic.Product#getProductId (defaulting to String.valueOf if not provided).
Including all documentation of course, that will include all warnings about performance implications and accessibility restrictions of course

@felixbarny
Copy link
Member

Capturing parameters will be challenging to do in a performant way. even if disabled, we would need to add @Advice.AllArguments Object[] args to the advice which allocates an array for the arguments even if not used.

@felixbarny felixbarny added type: enhancement instrumentation Instrumentation: framework support, custom plugins, ... labels Jan 30, 2019
@SylvainJuge SylvainJuge added enhancement Enhancement of an existing feature and removed [zube]: Backlog labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature instrumentation Instrumentation: framework support, custom plugins, ...
Projects
None yet
Development

No branches or pull requests

4 participants