Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Transaction Name for Spring Boot Actuators #513

Open
remmeier opened this issue Mar 5, 2019 · 1 comment
Open

Proper Transaction Name for Spring Boot Actuators #513

remmeier opened this issue Mar 5, 2019 · 1 comment
Labels
instrumentation Instrumentation: framework support, custom plugins, ...

Comments

@remmeier
Copy link

remmeier commented Mar 5, 2019

Calls to the Spring Boot Actuators are labels: "ControllerClassName#methodName". For many kinds and for many kinds of applications (like with Kubernetes and health checks), those endpoints will be called often. One can configure https://www.elastic.co/guide/en/apm/agent/java/current/config-http.html#config-use-path-as-transaction-name to make use of the path as transcation names, but this can lead to other issues. Since it is a common use case, would be great to have a good default for the Spring MVC integration to support the Actuators out-of-the-box with reasonable labels, probably the first path element would already be sufficient (and will mostly stay like that anyway, like /health).

@SylvainJuge
Copy link
Member

Hi @remmeier ,

Just to clarify here:

I'm not familiar with Actuator implementation details, do you know how (and if) we could identify which actuator endpoint is being called at runtime without relying on brittle URL parsing ? If yes, changing the current implementation would be quite straightforward.

It seems that there is a property management.endpoints.web.base-path that allows to set the path prefix (default /actuator), thus we could use that also.

@SylvainJuge SylvainJuge added instrumentation Instrumentation: framework support, custom plugins, ... and removed [zube]: Backlog labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation Instrumentation: framework support, custom plugins, ...
Projects
None yet
Development

No branches or pull requests

3 participants