Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP and ConnectionPool Metrics #595

Open
rdhanpal opened this issue Apr 17, 2019 · 8 comments
Open

HTTP and ConnectionPool Metrics #595

rdhanpal opened this issue Apr 17, 2019 · 8 comments
Labels
new-feature New feature

Comments

@rdhanpal
Copy link

rdhanpal commented Apr 17, 2019

Is your feature request related to a problem? Please describe.
Today apm-agent-java does not have the functionality to capture HTTP and JDBC Connection pool metrics for a Java Container(eg Tomcat, websphere liberty etc) and we rely on this pool stats to research any potential issues.

Describe the solution you'd like
Requesting for a feature to be added to apm-agent-java to capture http, jdbc connection pools

Enhancement request spawned off topic: https://discuss.elastic.co/t/http-and-jdbc-connectionpool-stats/177154

Thanks
Rahul

@felixbarny
Copy link
Member

Which JDBC connection pools are you most interested in?

Probably easier to implement once we have resolved #469

@rdhanpal
Copy link
Author

rdhanpal commented Apr 17, 2019

Which JDBC connection pools are you most interested in?

My understanding is that you are asking for JDBC driver implementation types I am interested in. If not, Can you elaborate more on this for me please ?

Thank You.

@felixbarny
Copy link
Member

I'm curious which DataSource implementations you are using. Some examples are org.apache.tomcat.jdbc.pool.DataSource, com.zaxxer.hikari.HikariDataSource, com.mchange.v2.c3p0.ComboPooledDataSource and org.apache.commons.dbcp2.BasicDataSource

@rdhanpal
Copy link
Author

we use javax.sql.ConnectionPoolDataSource ,javax.sql.XADataSource, org.apache.tomcat.jdbc.pool.DataSource and future integrations would be with com.datastax.oss and some of the JDBC drivers types we use are and not limited to sqljdbc6.jar, db2jcc4.jar and jt400.jar
Please let me know if this information helps.

@leandro-ss
Copy link

Hi

I'm interested too, in my case I need of metrics of Hibernate 5.4.2 JMX and metrics of Ehcache 3-JSR107 Monitoring acessible by JMX too.
Unfortunely today I need acess by JConsole or other tool, Jolokia plus Metricbeat is possible, but... ,
for my understanding is too much agents in application to get pratically the same information.

@wolframhaussig
Copy link
Contributor

We are interested too and we are using org.apache.commons.dbcp2.BasicDataSource

@eyalkoren
Copy link
Contributor

This is not in the immediate roadmap. For any framework that publishes metrics to the JMX, you can use the capture_jmx_metrics option to capture those.
If you do and want to share (the config and the related dashboard or anything else you did for viewing) with other users, you are welcome to do so through our contrib repo.

@SylvainJuge SylvainJuge added enhancement Enhancement of an existing feature new-feature New feature and removed [zube]: Backlog enhancement Enhancement of an existing feature labels Feb 1, 2021
@claudiobosticco
Copy link

has someone ever succeed in configuring it with dbcp2 ? @wolframhaussig by chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature
Projects
None yet
Development

No branches or pull requests

7 participants