Skip to content

BulkAll should classify retried and failed documents as dropped. #6647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mpdreamz opened this issue Aug 23, 2022 · 0 comments · Fixed by #6801
Closed

BulkAll should classify retried and failed documents as dropped. #6647

Mpdreamz opened this issue Aug 23, 2022 · 0 comments · Fixed by #6801
Labels
7.x Relates to a 7.x client version 8.x Relates to a 8.x client version
Milestone

Comments

@Mpdreamz
Copy link
Member

BulkAll has an option to continue after dropped documents:

bool ContinueAfterDroppedDocuments { get; }

HandleDroppedDocuments takes this setting into account and only throws an exception if we are not continueing after seeing dropped documents

HandleDroppedDocuments(droppedDocuments, response);

However later after retrying we through if we still hold retryableDocuments. This should also check this configuration setting and treat them as dropped documents:

However later we don't classify retried to completion bulk items as dropped and do not make this check conditional:

@Mpdreamz Mpdreamz added bug 8.x Relates to a 8.x client version labels Aug 23, 2022
@stevejgordon stevejgordon added the 7.x Relates to a 7.x client version label Oct 12, 2022
@stevejgordon stevejgordon modified the milestones: 7.17.5, 8.0.0 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Relates to a 7.x client version 8.x Relates to a 8.x client version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants