Skip to content

[FEATURE] Support missing DecayFunctions in FunctionScore #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevejgordon opened this issue Mar 22, 2023 · 9 comments · Fixed by #8249
Closed

[FEATURE] Support missing DecayFunctions in FunctionScore #7428

stevejgordon opened this issue Mar 22, 2023 · 9 comments · Fixed by #8249
Labels
Milestone

Comments

@stevejgordon
Copy link
Contributor

stevejgordon commented Mar 22, 2023

Due to certain complexities with the DecayFunction union in the specification, the code generator is currently skipping these on the FunctionScore container type, which prevents the use of gauss, exp and linear functions. We need to solve this in the code generator so that these functions can be reintroduced in the 8.x client.

Please update by adding a thumbs-up reaction to this comment if this is a blocker for you. This helps us prioritise the work on new features.

@stevejgordon stevejgordon added Feature 8.x Relates to a 8.x client version labels Mar 22, 2023
@stevejgordon stevejgordon changed the title [FEATURE] Support missing DecayFunctions in ScoreFunction [FEATURE] Support missing DecayFunctions in FunctionScore Mar 22, 2023
@stevejgordon stevejgordon added this to the Future milestone Apr 13, 2023
@oscarlofwenhamn
Copy link

Is there any way to, for example, inject manually written JSON into FunctionScore to make use of the decay functions, or is the realistic solution simply to use the 7.17.x client (as recommended in the project README), in the case where decay functions are required?

@stevejgordon
Copy link
Contributor Author

@oscarlofwenhamn You can't pass arbitrary JSON to FunctionScore. If this is the only blocker to upgrade, you could consider dropping to the Transport layer (available from the client instance), where you can send a complete request as JSON and handle the JSON response. Sticking with 7.17.x in compatibility mode until this is available is also an option.

@oscarlofwenhamn
Copy link

Clear and concise, thanks!

@ghost
Copy link

ghost commented Dec 12, 2023

Is this still not adressed?

@flobernd
Copy link
Member

@JanToreKyrdalen The code generator is currently being reworked to address this and other issues. A rough estimation for completion is end of Q1 2024.

@luisvsilva

This comment was marked as spam.

@eCorke
Copy link

eCorke commented Jun 6, 2024

So, how's it going? It's been a year and three months from the original post, and 6 moths since Q1 2024 rough estimates. Any good news?

@flobernd
Copy link
Member

flobernd commented Jun 6, 2024

Currently blocked until elastic/elasticsearch-specification#2545 is merged.

@flobernd
Copy link
Member

flobernd commented Jul 1, 2024

Implemented in 8.14.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants