Missing 'similarity' field in knn search request

[adrian-arapiles]

From 8.8 version, elasticsearch has field 'similarity' for search in knn field.
Right now, the api doesn't support this field and fail.

🐛 Missing type

https://www.elastic.co/guide/en/elasticsearch/reference/current/knn-search.html#_search_knn_with_expected_similarity
Unknown field 'similarity' (JSON path: similarity) (line no=2, column no=15, offset=16)

Definition

If possible provide a basic definition that we can use as base.
You can see here how to create a basic definition for any API.

[adrian-arapiles]

I tried to push a branch with the change, but I haven't permissions.

[pstrsr]

elastic/elasticsearch-java#643 Related.

I also tried to open a PR with the fix, but same issue.

[ezimuel]

@adrian-arapiles did you fork the project and send a PR from a branch in your fork? You cannot create a branch in the original repository. /cc @AlmostFamiliar

[pstrsr]

@ezimuel that worked. I have never tried making a PR for an OS project, thank you for helping out!

[JoshMock]

#2261 is merged and backported to 8.8, 8.9 and 8.10, so this should be fixed in the next patch release for each of those, or 8.11.0 when it releases.