-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/render_complete 👉 src/plugins/kibana_utils #44367
Comments
Pinging @elastic/kibana-app-arch |
I wonder if we need render complete helper at all, if we moved this logic inside embeddable api. Only problem is that we need to pass down a fn through many visualize layer to get it to the right spot which I think is what this render complete helper helps us avoid. visualize_embeddable.ts:
One way that's previous been discussed to avoid passing down a fn through many layer is to use triggers... but we still need an id of the embeddable so it knows how to map the caller to itself.
Not sure how else but embeddable id we could match the emitter of the trigger to the embeddable that should update its status. But if there is no easy fix right now in embeddables... do we really want to block np migration, or just barge ahead even knowing that this code should probably go away at some point. |
I agree that there might be a better way to organize this code but I'm still rather new to it but I don't have a recommendation. We should resolve this in v7.5 but we have some time to consider our options and doing other tasks might help clarify. |
ui/render_complete
👉src/plugins/kibana_utils
src/legacy/ui/public/render_complete/index.ts
src/legacy/ui/public/render_complete/render_complete_helper.ts
src/legacy/ui/public/render_complete/directive.js
, check it still worksParent issue: #44121
The text was updated successfully, but these errors were encountered: