Skip to content

Fixing hardcoded links #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sivakumar-kailasam opened this issue Mar 15, 2017 · 4 comments
Closed

Fixing hardcoded links #24

sivakumar-kailasam opened this issue Mar 15, 2017 · 4 comments

Comments

@sivakumar-kailasam
Copy link
Member

There are links hardcoded in the class descriptions that point to the existing url such as /api/data/classes/DS.ConflictError.html. These need to be corrected to point to the correct versioned url.

@sivakumar-kailasam
Copy link
Member Author

let $ = cheerio.load(markedup)
we could lookup links here and replace tehm with the path from the api docs ember app.

@toddjordan
Copy link
Contributor

@sivakumar-kailasam how high a priority is this? is it blocking any current functionality?

@sivakumar-kailasam
Copy link
Member Author

@toddjordan Not a blocker since we handle those redirects. Tracked to ensure that its being fixed.

@toddjordan
Copy link
Contributor

Closing since we are handling the case, and are not planning a fix anytime soon. If it becomes an issue again we can still address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants