Skip to content

Commit dd89193

Browse files
authored
Merge pull request #19645 from nlfurniss/remove-try-invoke
2 parents 5beb333 + c1aee95 commit dd89193

File tree

7 files changed

+1
-116
lines changed

7 files changed

+1
-116
lines changed

packages/@ember/-internals/utils/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export {
2323
} from './lib/super';
2424
export { default as inspect } from './lib/inspect';
2525
export { default as lookupDescriptor } from './lib/lookup-descriptor';
26-
export { canInvoke, tryInvoke } from './lib/invoke';
26+
export { canInvoke } from './lib/invoke';
2727
export { default as makeArray } from './lib/make-array';
2828
export { getName, setName } from './lib/name';
2929
export { default as toString } from './lib/to-string';
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { deprecate } from '@ember/debug';
2-
31
/**
42
Checks to see if the `methodName` exists on the `obj`.
53
@@ -25,52 +23,3 @@ export function canInvoke(obj: any | null | undefined, methodName: string): obj
2523
/**
2624
@module @ember/utils
2725
*/
28-
29-
/**
30-
Checks to see if the `methodName` exists on the `obj`,
31-
and if it does, invokes it with the arguments passed.
32-
33-
```javascript
34-
import { tryInvoke } from '@ember/utils';
35-
36-
let d = new Date('03/15/2013');
37-
38-
tryInvoke(d, 'getTime'); // 1363320000000
39-
tryInvoke(d, 'setFullYear', [2014]); // 1394856000000
40-
tryInvoke(d, 'noSuchMethod', [2014]); // undefined
41-
```
42-
43-
@method tryInvoke
44-
@for @ember/utils
45-
@static
46-
@param {Object} obj The object to check for the method
47-
@param {String} methodName The method name to check for
48-
@param {Array} [args] The arguments to pass to the method
49-
@return {*} the return value of the invoked method or undefined if it cannot be invoked
50-
@public
51-
@deprecated Use Javascript's optional chaining instead.
52-
*/
53-
export function tryInvoke(
54-
obj: any | undefined | null,
55-
methodName: string,
56-
args: Array<any | undefined | null>
57-
) {
58-
deprecate(
59-
`Use of tryInvoke is deprecated. Instead, consider using JavaScript's optional chaining.`,
60-
false,
61-
{
62-
id: 'ember-utils.try-invoke',
63-
until: '4.0.0',
64-
for: 'ember-source',
65-
since: {
66-
enabled: '3.24.0',
67-
},
68-
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-utils-try-invoke',
69-
}
70-
);
71-
72-
if (canInvoke(obj, methodName)) {
73-
let method = obj[methodName];
74-
return method.apply(obj, args);
75-
}
76-
}

packages/@ember/-internals/utils/tests/try_invoke_test.js

-60
This file was deleted.

packages/@ember/utils/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
export { isNone, isBlank, isEmpty, isPresent } from '@ember/-internals/metal';
2-
export { tryInvoke } from '@ember/-internals/utils';
32
export { compare, isEqual, typeOf } from '@ember/-internals/runtime';

packages/ember/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ Ember.guidFor = utils.guidFor;
220220
Ember.inspect = utils.inspect;
221221
Ember.makeArray = utils.makeArray;
222222
Ember.canInvoke = utils.canInvoke;
223-
Ember.tryInvoke = utils.tryInvoke;
224223
Ember.wrap = utils.wrap;
225224
Ember.uuid = utils.uuid;
226225

packages/ember/tests/reexports_test.js

-1
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,6 @@ let allExports = [
463463
['isEqual', '@ember/utils', 'isEqual'],
464464
['isNone', '@ember/utils', 'isNone'],
465465
['isPresent', '@ember/utils', 'isPresent'],
466-
['tryInvoke', '@ember/utils', 'tryInvoke'],
467466
['typeOf', '@ember/utils', 'typeOf'],
468467

469468
// @ember/version

tests/docs/expected.js

-1
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,6 @@ module.exports = {
571571
'trigger',
572572
'triggerAction',
573573
'triggerEvent',
574-
'tryInvoke',
575574
'trySet',
576575
'type',
577576
'typeInjection',

0 commit comments

Comments
 (0)