Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG angle-bracket-components] Unstable Top Level Elements #11728

Closed
chadhietala opened this issue Jul 13, 2015 · 5 comments
Closed

[BUG angle-bracket-components] Unstable Top Level Elements #11728

chadhietala opened this issue Jul 13, 2015 · 5 comments

Comments

@chadhietala
Copy link
Contributor

In the following jsbin there are 2 weird behaviors.

  1. Event handlers can become detached
  2. Top level DOM becomes unstable for no reason

I believe this is due to having an if helper on the top level element. I noticed that class names do not get concated with the existing ember-view class which may be the reasoning around the event handlers being removed.

Repro:
http://emberjs.jsbin.com/naqodocahe/edit?html,css,js,output

@pixelhandler
Copy link
Contributor

@chadhietala is there a way to add some logging to your jsbin example that demonstrates the event handlers no longer being attached.

What are the steps you noticed that may have contributed to the event handler becoming detached?
How is the top level DOM unstable?
Would a screen recording, posted on dropbox or something, showcase the unstableness to help this issue be reproducible?

@chancancode chancancode mentioned this issue Aug 8, 2015
20 tasks
@rwjblue
Copy link
Member

rwjblue commented Aug 8, 2015

@chadhietala - Can you submit a failing test PR for this? I'll add it to the checklist in #12011...

@wycats
Copy link
Member

wycats commented Aug 8, 2015

@rwjblue our branch is addressing exactly this case; it happens when the ember-view class becomes overridden by the inner template, which is really just a very special case of a much larger problem.

@rwjblue
Copy link
Member

rwjblue commented Aug 8, 2015

@wycats - AWESOME! Then your branch will make the requested failing test pass 😉

@chadhietala
Copy link
Contributor Author

Confirmed this was fixed in #12011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants