Skip to content

Support building with Java 21, drop Java 7 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexei-osipov opened this issue Oct 11, 2024 · 3 comments
Closed

Support building with Java 21, drop Java 7 #99

alexei-osipov opened this issue Oct 11, 2024 · 3 comments

Comments

@alexei-osipov
Copy link

Currently an attempt to build the DFP project with Java 21 result in error:

> Task :java:dfp:compileJava FAILED
error: Source option 7 is no longer supported. Use 8 or later.
error: Target option 7 is no longer supported. Use 8 or later.

This is caused by remaining support of Java 7 for DFP.

compileJava {
    sourceCompatibility = 1.7
    targetCompatibility = 1.7
}

We should support building at on least one LTS java version: Java 17 or Java 21.
I think we can drop support of Java 7 for simplicity.

@agdavydov81
Copy link

agdavydov81 commented Oct 14, 2024

Yes, the current master branch supports only Java 18 or 19 for jar compilation.
But this restriction is only about build environment and do not related to the runtime environment.
Yes, I know about Java 18 and 19 EOL, but I have a questions:

  1. Do our all (without exceptions) customers support Java 8 and ready for migration?
  2. What the profit we will get from this migration? I mean what features to the final product will be added?

I'm not against the migration, but right now I see only the Java 7 version dropping without any benefits.

@alexei-osipov
Copy link
Author

  1. Yes. All of them. There are no actively supported customers on Java 1.7. Even more, currently all projects on Java 11 at least.
  2. First of all, this improves project maintainability. Secondly, performance. Having Java 1.7 as target reduces the set of API's and optimizations that Java compiler can use.

@agdavydov81
Copy link

After R&D discussion this issue was resolved positively.
#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants