Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Move browserify transforms to package.json #87

Merged
merged 1 commit into from
Feb 28, 2015
Merged

Move browserify transforms to package.json #87

merged 1 commit into from
Feb 28, 2015

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Feb 27, 2015

Browserify will automatically read the package.json and run the transforms. This produces the exact same build as specifying the transforms in the gulpfile.js. Additionally, now when someone tries to externally browserify ethereum.js, it will use the same transforms as when you use gulp. Yay! Consistency!

Fixes #86
Fixes #36

@wanderer
Copy link

👍

@kumavis
Copy link
Contributor Author

kumavis commented Feb 27, 2015

I'm happy to provide further explanation, just ask

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.0% when pulling ee686b0 on kumavis:develop into 8cf8b9e on ethereum:develop.

@kumavis
Copy link
Contributor Author

kumavis commented Feb 28, 2015

@debris if there is anything I can do to help get this merged, let me know 😸

@debris
Copy link
Contributor

debris commented Feb 28, 2015

looks good! thanks!

debris added a commit that referenced this pull request Feb 28, 2015
Move browserify transforms to package.json
@debris debris merged commit 30111f7 into web3:develop Feb 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants