Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm blocktest does not seem to output traces when --debug or --json are passed #27363

Closed
d-xo opened this issue May 26, 2023 · 4 comments · Fixed by #27396
Closed

evm blocktest does not seem to output traces when --debug or --json are passed #27363

d-xo opened this issue May 26, 2023 · 4 comments · Fixed by #27396
Labels

Comments

@d-xo
Copy link

d-xo commented May 26, 2023

System information

Geth version: 1.11.6-stable
OS & Version: Linux

Expected behaviour

If I run evm --json statetest and pass a state test json, then evm will output per opcode traces, however running evm --json blocktest outputs nothing. The same is true when using --debug instead of --json. I would expect to be able to get json traces for both state and blockchain tests.

Actual behaviour

evm --json blocktest <FILE> and evm --debug blocktest <FILE> output nothing

Steps to reproduce the behaviour

evm --json blocktest <TEST_FILE>

@d-xo d-xo added the type:bug label May 26, 2023
@holiman
Copy link
Contributor

holiman commented May 30, 2023

[user@work go-ethereum]$ evm --json statetest  ./foo.txt
invalid character '\x1b' looking for beginning of value
[user@work go-ethereum]$ evm --json blocktest ./foo.txt
No help topic for 'blocktest'

There is no blocktest command. If you pass a blockchain test json to the statetest command, it will probably parse a statetest which is mostly empty, so no state transition to perform and no output to show.

@holiman holiman closed this as completed May 30, 2023
@d-xo
Copy link
Author

d-xo commented May 30, 2023

There has been an evm blocktest since 1.11.0 I believe? It was added in the follwing pr: #26526.

Certainly it is present in the go-ethereum 1.11.6 I have installed locally:

> evm blocktest --help
NAME:
   evm blocktest - executes the given blockchain tests

USAGE:
   evm blocktest [command options] <file>

OPTIONS:

    --help, -h                     (default: false)
          show help

@holiman
Copy link
Contributor

holiman commented May 30, 2023 via email

@d-xo
Copy link
Author

d-xo commented Jun 6, 2023

thanks for the fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants