-
-
Notifications
You must be signed in to change notification settings - Fork 326
type safety for provided? #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@philipbjorge - installed your fix from git, works like magic! @rmk135 is there any chance we could get it merge? |
Available in v4.46.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When referencing a singleton via
foo.provided.bar
, we lose type safety becauseprovided
always resolves to theProvidedInstance
rather than the specific type of the dependency.Expected
settings.provided
resolves toSettings
Actual
settings.provided
resolves toProvidedInstance
This seems like an easy change to make -- Is there any reason this wouldn't work if I opened a PR?
The text was updated successfully, but these errors were encountered: