-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Task 1 of Meltdown Mitigation is misleading #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@punkstarman 👋🏽 Thanks for logging this. Concept Exercises are quite different from the "regular" practice exercises that were carried over from V2. They're intended to teach a specific concept, and must only use the concepts introduced as part of their dependency tree. Since this concept exercise is designed to teach I am happy to have someone propose revisions / additions to this exercise provided that it thoroughly covers the use of Having said that - agree that multiple |
I've merged #2556. Please let me know if you have further questions/issues/comments. Thanks! |
PyLint is wrong in this instance. Multiple return statements is the right thing to do.
|
Suggest away! PRs on this welcome, with the caveats listed above. 😄 I will hold this issue open, and flag it as a discussion. |
I agree with this as long as the items are bools. I would not simply discard the good old |
Absolutely
I do not mean to discard it. I mean to make proper use of it in context. |
I am going to close this issue. The tasks in this exercise are being reviewed/revised, but we are unlikely to change |
One of the most common blunders a novice can make is to use if-elif-else blocks instead of using a single return statement.
For instance
should simply be written
The introduction sets up using
if:elif:else:
blocks. I fear that a novice will blindly fall into the trap of solving task 1 using anif
.or something even worse, when it should be solved with a single return statement.
The text was updated successfully, but these errors were encountered: