Skip to content

Stubs and examples can use linting #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IsaacG opened this issue Sep 14, 2021 · 3 comments
Closed

Stubs and examples can use linting #2582

IsaacG opened this issue Sep 14, 2021 · 3 comments
Assignees
Labels
on hold ✋🏽 Action should stop on this issue or PR for now. smolder🍲 Lower-priority and/or future idea

Comments

@IsaacG
Copy link
Member

IsaacG commented Sep 14, 2021

This is a superset of #2579 (long lines)

pylint flags all sorts of issues that ought to be cleaned up.

» find exercises -name \*.py ! -name \*_test.py -exec pylint -d C0116,W0613,C0114,C0115,C0103,R0801,W0707,W0107,C0301,R0903,W0511 {} +

Logging this is a "on hold, revisit later" type issue for now.

@BethanyG
Copy link
Member

..and as a superset of #2579, it has a hold for a similar reason. We need to have the track a bit more stable and a bit more filled out with concepts and concept exercises before we loop back for a discussion about practice stub files, line length, or any PyLint whining. We may also choose to not enforce some PyLint rules. That is still TBD.

Additionally - example files are more or less exempt from formal linting rules. It isn't that "anything goes" -- but the spec says nothing about them being any sort of exemplar, and they are at most a "minimum implementation" for use in CI and testing. It is a very low priority that we look through them all.

@BethanyG BethanyG added the on hold ✋🏽 Action should stop on this issue or PR for now. label Sep 14, 2021
@BethanyG BethanyG added the smolder🍲 Lower-priority and/or future idea label Oct 8, 2021
@J08K J08K self-assigned this Nov 15, 2021
@J08K J08K closed this as completed Nov 15, 2021
@J08K J08K reopened this Nov 15, 2021
@J08K
Copy link
Member

J08K commented Nov 15, 2021

Whoops, closed the wrong thing 💙

@J08K
Copy link
Member

J08K commented Nov 29, 2021

Closed by 8 PRs, linted all stubs and exemplars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold ✋🏽 Action should stop on this issue or PR for now. smolder🍲 Lower-priority and/or future idea
Projects
None yet
Development

No branches or pull requests

3 participants