From 856ccfe7afcd07bab7edc0ddc1dc369c742cac12 Mon Sep 17 00:00:00 2001 From: Ayoub-Mabrouk Date: Fri, 1 Nov 2024 03:30:08 +0100 Subject: [PATCH] Refactor JSONCookie function for clarity and compliance - Update JSDoc to clarify behavior and return types. - Replace str.substr(0, 2) with str.startsWith to check for the prefix 'j:'. - Simplify error handling by removing unused catch parameter. - Maintain functionality for parsing JSON cookies, returning undefined for invalid inputs. --- index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/index.js b/index.js index dd6d479..87164d7 100644 --- a/index.js +++ b/index.js @@ -76,18 +76,18 @@ function cookieParser (secret, options) { * Parse JSON cookie string. * * @param {String} str - * @return {Object} Parsed object or undefined if not json cookie + * @return {Object|undefined} Parsed object or undefined if not json cookie * @public */ function JSONCookie (str) { - if (typeof str !== 'string' || str.substr(0, 2) !== 'j:') { + if (typeof str !== 'string' || !str.startsWith('j:')) { return undefined } try { return JSON.parse(str.slice(2)) - } catch (err) { + } catch { return undefined } }