Skip to content

Commit 9bcdeb7

Browse files
diliopfacebook-github-bot
authored andcommitted
Update platform010 & platform010-aarch64 symlinks
Summary: `1.76.0` release with fixes addressing the following: * Release notes ([link](https://releases.rs/docs/1.76.0/)) * Most notable is [#118054](rust-lang/rust#118054) manifesting as: ``` error: unused implementer of `futures::Future` that must be used --> fbcode/mlx/metalearner/housekeeper/housekeeper.rs:213:13 | 213 | self.ping_oncall(&oncall, usecases); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: futures do nothing unless you `.await` or poll them = note: requested on the command line with `-D unused-must-use` ``` * Changes in `search_index.js` spec for `rustdoc` ([link](https://github.com/rust-lang/rust/pull/118910/files#diff-3ac57789ddcd2856a3b4f0c444f2813315179bdbe55bb945fe64fcb27b53fee5L491)) * Split of `#![feature(exposed_provenance)]` ([link](rust-lang/rust#118487)) from [#95228](rust-lang/rust#95228) * `buck2` OSS toolchain bump to `nightly-2023-12-11` just before [#11878](rust-lang/rust-clippy#11878) and a bunch of other clippy lint renames. Reviewed By: dtolnay Differential Revision: D53776867 fbshipit-source-id: 78db83d8cdd6b0abae2b94ed1075e67b501fcd73
1 parent 892fb0a commit 9bcdeb7

File tree

10 files changed

+15
-13
lines changed

10 files changed

+15
-13
lines changed

HACKING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ cargo install --path=app/buck2
2222
Or, alternatively, install it directly from GitHub:
2323

2424
```sh
25-
rustup install nightly-2023-11-10
26-
cargo +nightly-2023-11-10 install --git https://github.com/facebook/buck2.git buck2
25+
rustup install nightly-2023-12-11
26+
cargo +nightly-2023-12-11 install --git https://github.com/facebook/buck2.git buck2
2727
```
2828

2929
### Side note: using [Nix] to compile the source

app/buck2_audit_server/src/cell.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ impl AuditSubcommand for AuditCellCommand {
6666
}
6767

6868
pub(crate) fn audit_cell(
69-
aliases_to_resolve: &Vec<String>,
69+
aliases_to_resolve: &[String],
7070
aliases: bool,
7171
cells: &CellResolver,
7272
cwd: &ProjectRelativePath,

app/buck2_build_api/src/deferred/calculation.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ async fn compute_deferred(
313313
impl DeferredCompute {
314314
fn create_materializer_futs<'a>(
315315
&'a self,
316-
materialized_artifacts: &'a Vec<ArtifactGroup>,
316+
materialized_artifacts: &'a [ArtifactGroup],
317317
ctx: &'a DiceComputations,
318318
span: &'a Lazy<Option<Span>, impl FnOnce() -> Option<Span>>,
319319
) -> impl Future<Output = anyhow::Result<HashMap<Artifact, ProjectRelativePathBuf>>> + 'a

app/buck2_critical_path/src/graph.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ pub struct Graph {
2525

2626
impl Graph {
2727
#[inline]
28-
pub fn iter_vertices(&self) -> impl Iterator<Item = VertexId> + DoubleEndedIterator {
28+
pub fn iter_vertices(&self) -> impl DoubleEndedIterator<Item = VertexId> {
2929
self.vertices.keys()
3030
}
3131

app/buck2_critical_path/src/types.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -135,13 +135,13 @@ where
135135
Self(v, PhantomData)
136136
}
137137

138-
pub fn keys(&self) -> impl Iterator<Item = AbstractVertexId<Kind>> + DoubleEndedIterator {
138+
pub fn keys(&self) -> impl DoubleEndedIterator<Item = AbstractVertexId<Kind>> {
139139
// By construction the length of this is always less than the maximum vertex id.
140140
let len: u32 = self.0.len().try_into().unwrap();
141141
(0..len).map(AbstractVertexId::new)
142142
}
143143

144-
pub fn iter(&self) -> impl Iterator<Item = (AbstractVertexId<Kind>, &T)> + DoubleEndedIterator {
144+
pub fn iter(&self) -> impl DoubleEndedIterator<Item = (AbstractVertexId<Kind>, &T)> {
145145
self.keys().map(|k| (k, &self.0[k.0 as usize]))
146146
}
147147

@@ -208,7 +208,7 @@ where
208208
Self(v)
209209
}
210210

211-
pub fn iter(&self) -> impl Iterator<Item = (AbstractVertexId<Kind>, &K)> + DoubleEndedIterator {
211+
pub fn iter(&self) -> impl DoubleEndedIterator<Item = (AbstractVertexId<Kind>, &K)> {
212212
self.0.iter().map(|(key, idx)| (*idx, key))
213213
}
214214

app/buck2_error/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#![feature(error_generic_member_access)]
1111
#![feature(let_chains)]
1212
#![feature(trait_alias)]
13-
#![feature(trait_upcasting)]
13+
#![cfg_attr(fbcode_build, feature(trait_upcasting))]
1414

1515
mod any;
1616
pub mod classify;

docs/getting_started.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ To get started, first install [rustup](https://rustup.rs/), then compile the
1818
`buck2` executable:
1919

2020
```bash
21-
rustup install nightly-2023-11-10
22-
cargo +nightly-2023-11-10 install --git https://github.com/facebook/buck2.git buck2
21+
rustup install nightly-2023-12-11
22+
cargo +nightly-2023-12-11 install --git https://github.com/facebook/buck2.git buck2
2323
```
2424

2525
The above commands install `buck2` into a suitable directory, such as

rust-toolchain

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
# * NOTE: You may have to change this file in a follow up commit as ocamlrep
1010
# has a dependency on buck2 git trunk.
1111

12-
# @rustc_version: rustc 1.75.0-nightly (0f44eb32f 2023-11-09)
13-
channel = "nightly-2023-11-10"
12+
# @rustc_version: rustc 1.76.0-nightly (d86d65bbc 2023-12-10)
13+
channel = "nightly-2023-12-11"
1414
components = ["llvm-tools-preview","rustc-dev","rust-src"]

starlark-rust/starlark/src/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@
393393
// Features we use
394394
#![allow(stable_features)]
395395
#![allow(unknown_lints)] // for clippy::tuple_array_conversions
396+
#![cfg_attr(rust_nightly, allow(internal_features))]
396397
#![cfg_attr(rust_nightly, feature(const_type_id))]
397398
#![cfg_attr(rust_nightly, feature(core_intrinsics))]
398399
#![cfg_attr(rust_nightly, feature(cfg_sanitize))]

starlark-rust/starlark_map/src/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#![cfg_attr(rust_nightly, feature(core_intrinsics))]
2626
#![cfg_attr(rust_nightly, feature(portable_simd))]
2727
#![cfg_attr(rust_nightly, feature(cfg_version))]
28+
#![cfg_attr(rust_nightly, allow(internal_features))]
2829

2930
mod hash_value;
3031
mod hashed;

0 commit comments

Comments
 (0)