fix react-error-overlay linting errors

Author: maxsbelt

packages/react-error-overlay/src/__tests__/extract-source-map.js

@@ -16,15 +16,15 @@ test('extracts last source map directive', async () => {
 });
 
 test('errors when no source map', async () => {
-  expect.assertions(1);
-
   const testFileName = 'test.js';
+  let error;
   try {
     await extractSourceMapUrl(
       testFileName,
       `console.log('hi')\n\nconsole.log('bye')`
     );
   } catch (e) {
-    expect(e).toBe(`Cannot find a source map directive for ${testFileName}.`);
+    error = e;
   }
+  expect(error).toBe(`Cannot find a source map directive for ${testFileName}.`);
 });

packages/react-error-overlay/src/__tests__/get-source-map.js

@@ -52,12 +52,14 @@ test('error on a source map with unsupported encoding', async () => {
   const file = fs
     .readFileSync(resolve(__dirname, '../../fixtures/junk-inline.mjs'))
     .toString('utf8');
+  let error;
   try {
     await getSourceMap('/', file);
   } catch (e) {
-    expect(e instanceof Error).toBe(true);
-    expect(e.message).toBe(
-      'Sorry, non-base64 inline source-map encoding is not supported.'
-    );
+    error = e;
   }
+  expect(error instanceof Error).toBe(true);
+  expect(error.message).toBe(
+    'Sorry, non-base64 inline source-map encoding is not supported.'
+  );
 });

packages/react-error-overlay/src/__tests__/parser/generic.js

@@ -8,23 +8,25 @@
 import { parse } from '../../utils/parser';
 
 test('throws on null', () => {
-  expect.assertions(2);
+  let error;
   try {
     parse(null);
   } catch (e) {
-    expect(e instanceof Error).toBe(true);
-    expect(e.message).toBe('You cannot pass a null object.');
+    error = e;
   }
+  expect(error instanceof Error).toBe(true);
+  expect(error.message).toBe('You cannot pass a null object.');
 });
 
 test('throws on unparsable', () => {
-  expect.assertions(2);
+  let error;
   try {
     parse({});
   } catch (e) {
-    expect(e instanceof Error).toBe(true);
-    expect(e.message).toBe(
-      'The error you provided does not contain a stack trace.'
-    );
+    error = e;
   }
+  expect(error instanceof Error).toBe(true);
+  expect(error.message).toBe(
+    'The error you provided does not contain a stack trace.'
+  );
 });