Skip to content

Commit 4ec5c24

Browse files
committed
feat(eslint-config-react-app): support eslint-plugin-testing-library 4.x
BREAKING CHANGE: Requires eslint-plugin-testing-library@^4.x
1 parent fddce8a commit 4ec5c24

File tree

5 files changed

+25
-19
lines changed

5 files changed

+25
-19
lines changed

packages/eslint-config-react-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ This config also ships with optional Jest rules for ESLint (based on [`eslint-pl
3939
You'll first need to add the ESLint plugin for Jest (if you don't already have it installed).
4040

4141
```sh
42-
npm install --save-dev eslint-plugin-jest@^24.0.0 eslint-plugin-testing-library&^3.9.0
42+
npm install --save-dev eslint-plugin-jest@^24.0.0 eslint-plugin-testing-library@^4.0.0
4343
```
4444

4545
You can then enable these rules by adding the Jest config to the `extends` array in your ESLint config.

packages/eslint-config-react-app/jest.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,16 @@ module.exports = {
3636
// https://github.com/testing-library/eslint-plugin-testing-library
3737
'testing-library/await-async-query': 'error',
3838
'testing-library/await-async-utils': 'error',
39-
'testing-library/no-await-sync-query': 'warn',
39+
'testing-library/no-await-sync-query': 'error',
40+
'testing-library/no-container': 'error',
41+
'testing-library/no-debug': 'error',
4042
'testing-library/no-dom-import': ['error', 'react'],
43+
'testing-library/no-node-access': 'error',
44+
'testing-library/no-promise-in-fire-event': 'error',
4145
'testing-library/no-wait-for-empty-callback': 'error',
42-
'testing-library/no-wait-for-snapshot': 'error',
46+
'testing-library/prefer-find-by': 'error',
47+
'testing-library/prefer-screen-queries': 'error',
48+
'testing-library/render-result-naming-convention': 'error',
4349
},
4450
},
4551
],

packages/eslint-config-react-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"eslint-plugin-jsx-a11y": "^6.3.1",
2828
"eslint-plugin-react": "^7.20.3",
2929
"eslint-plugin-react-hooks": "^4.0.8",
30-
"eslint-plugin-testing-library": "^3.9.0"
30+
"eslint-plugin-testing-library": "^4.0.0"
3131
},
3232
"peerDependenciesMeta": {
3333
"eslint-plugin-jest": {

packages/react-error-overlay/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@
4444
"chalk": "2.4.2",
4545
"chokidar": "^3.4.3",
4646
"cross-env": "7.0.2",
47-
"eslint": "^7.11.0",
47+
"eslint": "^7.24.0",
4848
"eslint-config-react-app": "^6.0.0",
49-
"eslint-plugin-flowtype": "^5.2.0",
49+
"eslint-plugin-flowtype": "^5.6.0",
5050
"eslint-plugin-import": "^2.22.1",
51-
"eslint-plugin-jest": "^24.1.0",
52-
"eslint-plugin-jsx-a11y": "^6.3.1",
53-
"eslint-plugin-react": "^7.21.5",
51+
"eslint-plugin-jest": "^24.3.5",
52+
"eslint-plugin-jsx-a11y": "^6.4.1",
53+
"eslint-plugin-react": "^7.23.2",
5454
"eslint-plugin-react-hooks": "^4.2.0",
55-
"eslint-plugin-testing-library": "^3.9.2",
55+
"eslint-plugin-testing-library": "^4.0.0",
5656
"flow-bin": "^0.116.0",
5757
"html-entities": "1.3.1",
5858
"jest": "26.6.0",

packages/react-scripts/package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
"@babel/core": "7.12.3",
3232
"@pmmmwh/react-refresh-webpack-plugin": "0.4.3",
3333
"@svgr/webpack": "5.5.0",
34-
"@typescript-eslint/eslint-plugin": "^4.5.0",
35-
"@typescript-eslint/parser": "^4.5.0",
34+
"@typescript-eslint/eslint-plugin": "^4.21.0",
35+
"@typescript-eslint/parser": "^4.21.0",
3636
"babel-eslint": "^10.1.0",
3737
"babel-jest": "^26.6.0",
3838
"babel-loader": "8.1.0",
@@ -44,16 +44,16 @@
4444
"css-loader": "4.3.0",
4545
"dotenv": "8.2.0",
4646
"dotenv-expand": "5.1.0",
47-
"eslint": "^7.11.0",
47+
"eslint": "^7.24.0",
4848
"eslint-config-react-app": "^6.0.0",
49-
"eslint-plugin-flowtype": "^5.2.0",
49+
"eslint-plugin-flowtype": "^5.6.0",
5050
"eslint-plugin-import": "^2.22.1",
51-
"eslint-plugin-jest": "^24.1.0",
52-
"eslint-plugin-jsx-a11y": "^6.3.1",
53-
"eslint-plugin-react": "^7.21.5",
51+
"eslint-plugin-jest": "^24.3.5",
52+
"eslint-plugin-jsx-a11y": "^6.4.1",
53+
"eslint-plugin-react": "^7.23.2",
5454
"eslint-plugin-react-hooks": "^4.2.0",
55-
"eslint-plugin-testing-library": "^3.9.2",
56-
"eslint-webpack-plugin": "^2.5.2",
55+
"eslint-plugin-testing-library": "^4.0.0",
56+
"eslint-webpack-plugin": "^2.5.3",
5757
"file-loader": "6.1.1",
5858
"fs-extra": "^9.0.1",
5959
"html-webpack-plugin": "4.5.0",

0 commit comments

Comments
 (0)