-
-
Notifications
You must be signed in to change notification settings - Fork 27k
RFC: Support for eslint-plugin-compat #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's pretty cool. Let's take another look at this after #1249. |
Great! This actually works with the https://github.com/amilajack/eslint-plugin-compat-demo/blob/master/package.json#L9 |
Do you want to send a PR for this? |
Sure! I don't know how CRA internals work. Which |
Thanks. I'll start working on this |
How would polyfills work in something like CRA? Excited to see your PR. |
Is there a way how to use this with create-react-app 2.0 nowadays? |
Is this being worked on? Can I open a PR for this? |
I wanted to wait to implement better polyfill and babel interoperability to the plugin before making a PR for this. I'll respond here again once I've implemented it. |
It detects if you're using babel or TS and if you are, it assumes all ES APIs are polyfilled and lints only WebAPIs |
@morsdyce The plugin should be good to implement now! |
@gaearon You last wrote on this 2 years ago. Would you still accept a PR for this? Or is CRA headed in another direction? |
Recently I've been working on an eslint plugin called eslint-plugin-compat that lints support for API's by using the caniuse db. It seems there is demand from the community for this plugin. Wonder if it has a place in create-react-app. Would a PR for it be welcome?
Here's a demo of it in action
Also planning to add integration with
babel-preset-env
andbrowserlist
The text was updated successfully, but these errors were encountered: