Skip to content

Atom indicating Definition for rule 'react/jsx-sort-prop-types' was not found #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisahardie opened this issue Feb 6, 2017 · 8 comments

Comments

@chrisahardie
Copy link

chrisahardie commented Feb 6, 2017

I am attempting to have Atom show me linting issues in the editor by following these instructions.

Every javscript file I open produces this ESLint warning: "Definition for rule 'react/jsx-sort-prop-types' was not found"

This is related to the removal of this rule here.

I presume the ESLint configuration is referencing this removed rule, but I'm at a loss trying to identify where exactly.

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected): web-poc@0.1. C:\Users\cha\Documents\Repos\poc `-- (empty)
  2. node -v: v.4.6.1
  3. npm -v: 4.2.0

Then, specify:

  1. Operating system: Windows 10
  2. Browser and version: N/A
@gaearon
Copy link
Contributor

gaearon commented Feb 6, 2017

Would you like to send a PR to fix our ESLint config to point to the different rule name?

@chrisahardie
Copy link
Author

@gaearon I'd be happy to, but I'm trying to run down exactly where this is configured - I'm afraid I'm still trying to figure out how everything is hanging together.

I presume that the configurations are set in this file? There is no jsx-sort-prop-types rule set there, is there somewhere else I should look? Or is it clear at this point that this issue is local to my machine?

@gaearon
Copy link
Contributor

gaearon commented Feb 6, 2017

That's the right file. If the rule was renamed we should probably rename it there too?

@chrisahardie
Copy link
Author

@gaearon From what I can tell, the jsx-sort-prop-types rule was never defined in that file, so unless it was set elsewhere by some other mechanism, I'm at a loss as to why I am seeing this error in Atom.

If that is indeed the only spot where this rule can be defined, then please close this issue and I'll try to figure out why this issue is presenting itself on my machine.

@gaearon
Copy link
Contributor

gaearon commented Feb 6, 2017

Maybe you have an .eslintrc somewhere up the directory tree?

@chrisahardie
Copy link
Author

@gaearon Sigh, you are correct. There was an unexpected .eslintrc up the directory tree which was causing this issue. Sorry for non-issue, I owe you a beer.

giphy

@gaearon
Copy link
Contributor

gaearon commented Feb 6, 2017

No worries! 👍

@bcbrian
Copy link

bcbrian commented Oct 24, 2017

Wow been struggling with this for months! Gave up and just stumbled on this :)

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants