Skip to content

Commit 175d796

Browse files
authored
fix: Make generated temp table name escaped (#3797)
* Fix critical issue with saving results in BigQuery Need to encapsulate table path as tmp table path can contain symbols that can't be process by BigQuery without encapsulation Signed-off-by: Dmytro Miedviediev <beardimon2001@gmail.com> * update numpy Signed-off-by: Dmytro Miedviediev <beardimon2001@gmail.com> * revert numpy version Signed-off-by: Dmytro Miedviediev <beardimon2001@gmail.com> --------- Signed-off-by: Dmytro Miedviediev <beardimon2001@gmail.com>
1 parent 7376db8 commit 175d796

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sdk/python/feast/infra/offline_stores/bigquery.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ def to_bigquery(
515515
temp_dest_table = f"{tmp_dest['projectId']}.{tmp_dest['datasetId']}.{tmp_dest['tableId']}"
516516

517517
# persist temp table
518-
sql = f"CREATE TABLE `{dest}` AS SELECT * FROM {temp_dest_table}"
518+
sql = f"CREATE TABLE `{dest}` AS SELECT * FROM `{temp_dest_table}`"
519519
self._execute_query(sql, timeout=timeout)
520520

521521
print(f"Done writing to '{dest}'.")

0 commit comments

Comments
 (0)